openstack
/
openstacksdk
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review-1

(4 comments)

Patch-set: 7
Reviewer: Gerrit User 15334 <15334@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 1c4a7aa38809af9e179cc00dcaa283a58994f5d3
Attention: {"person_ident":"Gerrit User 15334 \u003c15334@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36482 \u003c36482@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_15334\u003e replied on the change"}
This commit is contained in:
Gerrit User 15334 2024-05-08 16:32:15 +00:00 committed by Gerrit Code Review
parent 5c066de9b2
commit 408b81f130
2 changed files with 73 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
3e4dde7559007152b28864c1ca513c40d24ef175 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "f0291993_693ff4d0",
"filename": "openstack/cloud/_identity.py",
"patchSetId": 7
},
"lineNbr": 1130,
"author": {
"id": 15334
},
"writtenOn": "2024-05-08T16:32:15Z",
"side": 1,
"message": "Can you wrap this to \u003c\u003d 79 characters?",
"revId": "3e4dde7559007152b28864c1ca513c40d24ef175",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d149a9b1_da8e2f97",
"filename": "openstack/cloud/_identity.py",
"patchSetId": 7
},
"lineNbr": 1153,
"author": {
"id": 15334
},
"writtenOn": "2024-05-08T16:32:15Z",
"side": 1,
"message": "and this",
"revId": "3e4dde7559007152b28864c1ca513c40d24ef175",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "10a6e8c8_5d598799",
"filename": "openstack/cloud/_identity.py",
"patchSetId": 7
},
"lineNbr": 1198,
"author": {
"id": 15334
},
"writtenOn": "2024-05-08T16:32:15Z",
"side": 1,
"message": "And this",
"revId": "3e4dde7559007152b28864c1ca513c40d24ef175",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

18
43b511e064ea178b3746caa1d6272767740d13da
View File

@ -106,6 +106,24 @@
"revId": "43b511e064ea178b3746caa1d6272767740d13da",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b91b2540_b7b3b0d7",
"filename": "openstack/identity/v3/role_assignment.py",
"patchSetId": 6
},
"lineNbr": 31,
"author": {
"id": 15334
},
"writtenOn": "2024-05-08T16:32:15Z",
"side": 1,
"message": "As discussed today, we should drop this: it\u0027s not valid.\n\nWe should also drop these (but in a follow-up):\n\n```\n \u0027group_id\u0027,\n \u0027role_id\u0027,\n \u0027scope_domain_id\u0027,\n \u0027scope_project_id\u0027,\n \u0027user_id\u0027,\n```",
"parentUuid": "dfeda7ce_e4e74c2e",
"revId": "43b511e064ea178b3746caa1d6272767740d13da",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {