openstack
/
openstacksdk
Code Issues Proposed changes

mypy: Add typing to openstack._log 

A nice easy one to start.

Change-Id: I9a08341002cbf90ba9dccaacaa5f2d3e7d7560a2
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane 2023-07-27 11:40:14 +01:00
parent 554dc6284c
commit d506b9ff49
1 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
openstack/_log.py
View File

@ -14,9 +14,14 @@
import logging import logging
import sys import sys
import typing as ty
def setup_logging(name, handlers=None, level=None): def setup_logging(
name: str,
handlers: ty.Optional[ty.List[logging.Handler]] = None,
level: ty.Optional[int] = None,
) -> logging.Logger:
"""Set up logging for a named logger. """Set up logging for a named logger.
Gets and initializes a named logger, ensuring it at least has a Gets and initializes a named logger, ensuring it at least has a
@ -34,8 +39,7 @@ def setup_logging(name, handlers=None, level=None):
handlers = handlers or [] handlers = handlers or []
log = logging.getLogger(name) log = logging.getLogger(name)
if len(log.handlers) == 0 and not handlers: if len(log.handlers) == 0 and not handlers:
h = logging.NullHandler() log.addHandler(logging.NullHandler())
log.addHandler(h)
for h in handlers: for h in handlers:
log.addHandler(h) log.addHandler(h)
if level: if level:
@ -44,14 +48,14 @@ def setup_logging(name, handlers=None, level=None):
def enable_logging( def enable_logging(
debug=False, debug: bool = False,
http_debug=False, http_debug: bool = False,
path=None, path: ty.Optional[str] = None,
stream=None, stream: ty.Optional[ty.TextIO] = None,
format_stream=False, format_stream: bool = False,
format_template='%(asctime)s %(levelname)s: %(name)s %(message)s', format_template: str = '%(asctime)s %(levelname)s: %(name)s %(message)s',
handlers=None, handlers: ty.Optional[ty.List[logging.Handler]] = None,
): ) -> None:
"""Enable logging output. """Enable logging output.
Helper function to enable logging. This function is available for Helper function to enable logging. This function is available for