From 5742ebe17dc867981e582a4dc0445d37895775be Mon Sep 17 00:00:00 2001 From: yenai Date: Thu, 20 Sep 2018 14:14:00 +0800 Subject: [PATCH] Improve docstrings Change-Id: I512aa8fafd194eb22dc8c08942964f7d82534377 --- os_brick/initiator/connectors/iscsi.py | 5 +++-- os_brick/initiator/linuxscsi.py | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/os_brick/initiator/connectors/iscsi.py b/os_brick/initiator/connectors/iscsi.py index b364485c8..b827454df 100644 --- a/os_brick/initiator/connectors/iscsi.py +++ b/os_brick/initiator/connectors/iscsi.py @@ -109,7 +109,8 @@ class ISCSIConnector(base.BaseLinuxConnector, base_iscsi.BaseISCSIConnector): """Get iSCSI session information as a list of tuples. Uses iscsiadm -m session and from a command output like - tcp: [1] 192.168.121.250:3260,1 iqn.2010-10.org.openstack:volume- + tcp: [1] 192.168.121.250:3260,1 iqn.2010-10.org.openstack: + volume- (non-flash) This method will drop the node type and return a list like this: [('tcp:', '1', '192.168.121.250:3260', '1', @@ -135,7 +136,7 @@ class ISCSIConnector(base.BaseLinuxConnector, base_iscsi.BaseISCSIConnector): def _get_iscsi_nodes(self): """Get iSCSI node information (portal, iqn) as a list of tuples. - Uses iscsi_adm -m node and from a command output like + Uses iscsiadm -m node and from a command output like 192.168.121.250:3260,1 iqn.2010-10.org.openstack:volume This method will drop the tpgt and return a list like this: diff --git a/os_brick/initiator/linuxscsi.py b/os_brick/initiator/linuxscsi.py index a79962eaa..930b28f13 100644 --- a/os_brick/initiator/linuxscsi.py +++ b/os_brick/initiator/linuxscsi.py @@ -615,7 +615,7 @@ class LinuxSCSI(executor.Executor): """Find the device name given a session and the hctl. :param session: A string with the session number - "param hctl: An iterable with the host, channel, target, and lun as + :param hctl: An iterable with the host, channel, target, and lun as passed to scan. ie: ('5', '-', '-', '0') """ if '-' in hctl: