openstack
/
os-traits
Code Issues Proposed changes

update pep8/hacking and address failures 

update to necessary hacking from global requirements and fix up the
linting failures.

Change-Id: Ie6baa9e1b97ea3e1b61a418b00b64d1be391866a
This commit is contained in:
Jay Pipes 2017-03-02 11:35:12 -05:00
parent e4bfa8c4e0
commit 6f4b514145
4 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.gitreview Normal file
View File

@ -0,0 +1,4 @@
[gerrit]
host=review.openstack.org
port=29418
project=openstack/os-traits.git

13
os_traits/__init__.py
View File

@ -21,12 +21,11 @@ __version__ = pbr.version.VersionInfo(
'os_traits').version_string() 'os_traits').version_string()
# Conveniently import all the constants into the main module "namespace" # Conveniently import all the constants into the main module "namespace"
from os_traits.const import * from os_traits.const import * # noqa
def get_symbol_names(prefix=None): def get_symbol_names(prefix=None):
""" """Returns the names of symbols of trait strings in the os_traits module,
Returns the names of symbols of trait strings in the os_traits module,
optionally filtered by a supplied prefix. optionally filtered by a supplied prefix.
:param prefix: Optional string prefix to filter by. e.g. 'hw:' :param prefix: Optional string prefix to filter by. e.g. 'hw:'
@ -45,9 +44,8 @@ def get_symbol_names(prefix=None):
def get_traits(prefix=None): def get_traits(prefix=None):
""" """Returns the trait strings in the os_traits module, optionally filtered
Returns the trait strings in the os_traits module, optionally by a supplied prefix.
filtered by a supplied prefix.
:param prefix: Optional string prefix to filter by. e.g. 'hw:' :param prefix: Optional string prefix to filter by. e.g. 'hw:'
""" """
@ -65,8 +63,7 @@ def get_traits(prefix=None):
def check_traits(traits): def check_traits(traits):
""" """Returns a tuple of two trait string sets, the first set contains valid
Returns a tuple of two trait string sets, the first set contains valid
traits, and the second contains others. traits, and the second contains others.
:param traits: An iterable contains trait strings. :param traits: An iterable contains trait strings.

2
test-requirements.txt
View File

@ -2,7 +2,7 @@
# of appearance. Changing the order has an impact on the overall integration # of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later. # process, which may cause wedges in the gate later.
hacking<0.11,>=0.10.0 hacking>=0.12.0,!=0.13.0,<0.14 # Apache-2.0
coverage>=3.6 # Apache-2.0 coverage>=3.6 # Apache-2.0
python-subunit>=0.0.18 # Apache-2.0/BSD python-subunit>=0.0.18 # Apache-2.0/BSD

2
tox.ini
View File

@ -59,6 +59,6 @@ commands = oslo_debug_helper {posargs}
# E123, E125 skipped as they are invalid PEP-8. # E123, E125 skipped as they are invalid PEP-8.
show-source = True show-source = True
ignore = E123,E125 ignore = E123,E125,H405
builtins = _ builtins = _
exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,build exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,build