Merge "Use daemon property instead of setDaemon method"

os_win/tests/unit/utils/io/test_namedpipe.py

@@ -76,11 +76,11 @@ class NamedPipeTestCase(test_base.BaseTestCase):
         thread = namedpipe.threading.Thread
         thread.assert_has_calls(
             [mock.call(target=self._handler._read_from_pipe),
-             mock.call().setDaemon(True),
              mock.call().start(),
              mock.call(target=self._handler._write_to_pipe),
-             mock.call().setDaemon(True),
              mock.call().start()])
+        for worker in self._handler._workers:
+            self.assertIs(True, worker.daemon)
 
     @mock.patch.object(namedpipe.NamedPipeHandler, 'stop')
     @mock.patch.object(namedpipe.NamedPipeHandler, '_open_pipe')

os_win/utils/compute/clusterutils.py

@@ -605,7 +605,7 @@ class _ClusterEventListener(object):
         # If eventlet monkey patching is used, this will actually be a
         # greenthread. We just don't want to enforce eventlet usage.
         worker = threading.Thread(target=self._listen)
-        worker.setDaemon(True)
+        worker.daemon = True
 
         self._running = True
         worker.start()

os_win/utils/io/namedpipe.py

@@ -66,7 +66,7 @@ class NamedPipeHandler(object):
 
             for job in jobs:
                 worker = threading.Thread(target=job)
-                worker.setDaemon(True)
+                worker.daemon = True
                 worker.start()
                 self._workers.append(worker)
         except Exception as err: