oslo.concurrency/a937c5562f7cca721972822d72a...

116 lines
3.3 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "48da0497_2ae0b936",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 31245
},
"writtenOn": "2022-04-05T10:25:18Z",
"side": 1,
"message": "Looks good to me, I will add workflow on it.",
"revId": "a937c5562f7cca721972822d72ae7d2915bd5d52",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "8576bf0e_fce0fdb4",
"filename": "oslo_concurrency/processutils.py",
"patchSetId": 1
},
"lineNbr": 332,
"author": {
"id": 31412
},
"writtenOn": "2024-01-31T03:17:15Z",
"side": 1,
"message": "python2 has not effect right?",
"range": {
"startLine": 332,
"startChar": 4,
"endLine": 332,
"endChar": 67
},
"revId": "a937c5562f7cca721972822d72ae7d2915bd5d52",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "118bc75c_e3e93d8d",
"filename": "oslo_concurrency/processutils.py",
"patchSetId": 1
},
"lineNbr": 332,
"author": {
"id": 9816
},
"writtenOn": "2024-02-02T12:43:38Z",
"side": 1,
"message": "Can you elaborate what\u0027s your concern ? We removed support for python 2 a long ago so I don\u0027t know why you care about python2 here.",
"parentUuid": "8576bf0e_fce0fdb4",
"range": {
"startLine": 332,
"startChar": 4,
"endLine": 332,
"endChar": 67
},
"revId": "a937c5562f7cca721972822d72ae7d2915bd5d52",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "66f1994c_3001f785",
"filename": "oslo_concurrency/processutils.py",
"patchSetId": 1
},
"lineNbr": 332,
"author": {
"id": 31412
},
"writtenOn": "2024-02-07T01:56:27Z",
"side": 1,
"message": "our some products still use python2, so we are checking wether to merge this patch.",
"parentUuid": "118bc75c_e3e93d8d",
"range": {
"startLine": 332,
"startChar": 4,
"endLine": 332,
"endChar": 67
},
"revId": "a937c5562f7cca721972822d72ae7d2915bd5d52",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f5bfd5ea_e498705e",
"filename": "oslo_concurrency/processutils.py",
"patchSetId": 1
},
"lineNbr": 332,
"author": {
"id": 9816
},
"writtenOn": "2024-02-07T02:36:24Z",
"side": 1,
"message": "In OpenStack we globally dropped python 2 support and we no longer guarantee our lastet code is compatible with python 2.\n\nAt the first glance this may not but we do no longer guarantee our code works in python 2, especially since we removed six from most of the components.",
"parentUuid": "66f1994c_3001f785",
"range": {
"startLine": 332,
"startChar": 4,
"endLine": 332,
"endChar": 67
},
"revId": "a937c5562f7cca721972822d72ae7d2915bd5d52",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}