From a84c946767af552deda29cba118f532348444ff8 Mon Sep 17 00:00:00 2001 From: Kenneth Giusti Date: Tue, 3 Jul 2018 13:38:46 -0400 Subject: [PATCH] No longer allow redundant calls to server start() This has been deprecated since before Ocata. Change-Id: I659cc690c0a5d4f82349c7c4882c34c9c82e8a8a Closes-Bug: #1712397 --- oslo_messaging/server.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/oslo_messaging/server.py b/oslo_messaging/server.py index d2e50ac46..b889322a4 100644 --- a/oslo_messaging/server.py +++ b/oslo_messaging/server.py @@ -395,13 +395,11 @@ class MessageHandlingServer(service.ServiceBase, _OrderedTaskRunner): choose to dispatch messages in a new thread, coroutine or simply the current thread. """ - # Warn that restarting will be deprecated if self._started: - LOG.warning(_LW('Restarting a MessageHandlingServer is inherently ' - 'racy. It is deprecated, and will become a noop ' - 'in a future release of oslo.messaging. If you ' - 'need to restart MessageHandlingServer you should ' - 'instantiate a new object.')) + LOG.warning(_LW('The server has already been started. Ignoring' + ' the redundant call to start().')) + return + self._started = True executor_opts = {}