openstack
/
oslo.privsep
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
Attention: {"person_ident":"Gerrit User 4523 \u003c4523@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35063\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 35063 \u003c35063@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35063\u003e replied on the change"}
This commit is contained in:
Gerrit User 35063 2023-05-30 17:14:21 +00:00 committed by Gerrit Code Review
parent e519179f27
commit 00d68a7764
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
e9954f323969220da39a33fe45c2a8fabdad848e
View File

@ -16,6 +16,24 @@
"message": "I don\u0027t think fixing this issue requires a privsep change.\n\nMy idea was to create a new privsep context in os_brick with a different log level set, which can be done just from os_brick w/o changing privsep.",
"revId": "e9954f323969220da39a33fe45c2a8fabdad848e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1d9b56b2_95431ecc",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 35063
},
"writtenOn": "2023-05-30T17:14:21Z",
"side": 1,
"message": "I did try that with changing the decorator on get_connector_password() here https://opendev.org/openstack/os-brick/src/commit/ccda511ed531c872cb23b5cdc07067ea2e6cb32a/os_brick/privileged/scaleio.py#L78\n\nBut the password was still getting leaked. This patch was the only way I was able to hide the password (Unless I did not properly create a privsep context)",
"parentUuid": "53c1aec1_2a757306",
"revId": "e9954f323969220da39a33fe45c2a8fabdad848e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}