openstack
/
oslo.service
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(3 comments)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 28522 \u003c28522@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36102\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36102 \u003c36102@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36102\u003e replied on the change"}
This commit is contained in:
Gerrit User 36102 2024-04-04 23:58:14 +00:00 committed by Gerrit Code Review
parent 6e0738dff3
commit 1dbe5d44c2
2 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
a6216acc3ba4114390a20eb0194cc5eec10e0157
View File

@ -293,6 +293,30 @@
"revId": "a6216acc3ba4114390a20eb0194cc5eec10e0157",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a84692e2_4535565a",
"filename": "temp/eventlet_wsgi.py",
"patchSetId": 2
},
"lineNbr": 15,
"author": {
"id": 36102
},
"writtenOn": "2024-04-04T23:58:14Z",
"side": 1,
"message": "Done",
"parentUuid": "c19d6f25_3ef5c83f",
"range": {
"startLine": 15,
"startChar": 4,
"endLine": 15,
"endChar": 15
},
"revId": "a6216acc3ba4114390a20eb0194cc5eec10e0157",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {

48
f02d71709aa2cd33674a6600f768ae9c45f85281
View File

@ -23,6 +23,30 @@
"revId": "f02d71709aa2cd33674a6600f768ae9c45f85281",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "cb277f2c_711276cc",
"filename": "oslo_service/wsgi_new.py",
"patchSetId": 5
},
"lineNbr": 86,
"author": {
"id": 36102
},
"writtenOn": "2024-04-04T23:58:14Z",
"side": 1,
"message": "Hey,\n\nYes - I probably should have explained in detail why this is here.\n\nYou are 100% correct, it is not needed for it to run, and I have not included it when I was writing it originally. But it seems, for testing purposes, I might need to do shenanigans for exactly this reason - eventlets monkey patching seems to be escaping in different places.\n\nI will continue to experiment... maybe I accidentally patched somewhere.",
"parentUuid": "e2af8e23_d997b456",
"range": {
"startLine": 86,
"startChar": 8,
"endLine": 86,
"endChar": 53
},
"revId": "f02d71709aa2cd33674a6600f768ae9c45f85281",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -45,6 +69,30 @@
},
"revId": "f02d71709aa2cd33674a6600f768ae9c45f85281",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3ba508a0_8a2be925",
"filename": "temp/eventlet_wsgi.py",
"patchSetId": 5
},
"lineNbr": 22,
"author": {
"id": 36102
},
"writtenOn": "2024-04-04T23:58:14Z",
"side": 1,
"message": "Hmm. I did this because I was getting a pep8 error - it doesn\u0027t seem to be related to my issue.",
"parentUuid": "c758169f_8f6045ac",
"range": {
"startLine": 22,
"startChar": 0,
"endLine": 22,
"endChar": 23
},
"revId": "f02d71709aa2cd33674a6600f768ae9c45f85281",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}