openstack
/
osprofiler
Code Issues Proposed changes

[stable-only] Cap virtualenv/setuptools 

With latest virtualenv release (20.24.0) and its bundled setuptools
version, stable/victoria gates started to fail [1], because setuptools
is not compatible with the pbr version (5.5.0) which is in victoria
branch's upper constraint [2]. pbr's next release (5.5.1) removed the
failing code, this is why the change is only needed in stable/victoria.

This patch caps virtualenv to <20.24.0 to fix stable/victoria's gate,
and also caps tox for the 'inner' virtualenv, otherwise tox>4 would be
installed, that would introduce failures (those failures are fixed in
newer stable branches, but it would need several backports and 'outer'
tox is capped <4 anyway, so no worth dealing with it here).

[1] AttributeError: module 'setuptools.command.easy_install' has no attribute 'get_script_header'
[2] 636b6b3bde/upper-constraints.txt (L44)

Change-Id: I3475dbe6f18dc129da21c5839cb770775d8688d6
This commit is contained in:
Elod Illes 2023-07-17 17:22:53 +02:00
parent 80c4f13c21
commit 38d14c5b7e
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tox.ini
View File

@ -4,6 +4,12 @@ minversion = 3.1.0
skipsdist = False
envlist = py38,pep8
ignore_basepython_conflict = True
# Cap setuptools via virtualenv to prevent compatibility issue with victoria
# branch's upper constraint of pbr package (5.5.0). Tox is also needed to be
# constrained for the 'inner' tox to be installed with the constrained venv.
requires =
virtualenv<20.24.0
tox<4
[testenv]
basepython = python3