From 975fe2382dd42cbdcaa9620c3f29693040c6681f Mon Sep 17 00:00:00 2001 From: Claudiu Belu Date: Wed, 6 Sep 2017 09:15:36 -0700 Subject: [PATCH] Deduplicates optional_feature tests The optional_feature mixin's tests can use the _check_resize helper method, reducing the code duplication. Change-Id: I3e3c9be1fe5ba3629e9c7b8db4917c421ce7bd71 --- oswin_tempest_plugin/tests/_mixins/optional_feature.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/oswin_tempest_plugin/tests/_mixins/optional_feature.py b/oswin_tempest_plugin/tests/_mixins/optional_feature.py index 9a5189b..11651ee 100644 --- a/oswin_tempest_plugin/tests/_mixins/optional_feature.py +++ b/oswin_tempest_plugin/tests/_mixins/optional_feature.py @@ -77,14 +77,10 @@ class _OptionalFeatureMixin(resize._ResizeUtils): 'Resize is not available.') def test_resize_add_feature(self): new_flavor = self._get_flavor_ref() - server_tuple = self._create_server(self._FLAVOR_REF) - self._resize_server(server_tuple, new_flavor) - self._check_server_connectivity(server_tuple) + self._check_resize(new_flavor, self._FLAVOR_REF) @testtools.skipUnless(CONF.compute_feature_enabled.resize, 'Resize is not available.') def test_resize_remove_feature(self): - vanilla_flavor = self._FLAVOR_REF - server_tuple = self._create_server() - self._resize_server(server_tuple, vanilla_flavor) - self._check_server_connectivity(server_tuple) + new_flavor = self._get_flavor_ref() + self._check_resize(self._FLAVOR_REF, new_flavor)