From 1477c6cee6e3a192a897f50ae51100545fecd0ff Mon Sep 17 00:00:00 2001
From: Jakub Libosvar <libosvar@redhat.com>
Date: Fri, 21 Sep 2018 11:19:12 +0000
Subject: [PATCH] ut: Patch get_ident for race transaction test

In case eventlet is installed on the system, the time.sleep() function
doesn't yield.  This patch replaces time.sleep with eventlet.sleep and
thread.get_ident functions on systems with eventlet installed. With this
patch, a concurrent transaction test can be executed both with and
without eventlet successfuly.

Change-Id: I4572355d7d420111e562d4d1f4ea3dd95d4e3f7d
Related-bug: #1793499
(cherry picked from commit 64342ba52cc3e80b91ea0c845c349d2ce386f4ae)
(cherry picked from commit 057eeb319c47fb27d8067410593297dca6e1e097)
---
 ovsdbapp/tests/unit/test_api.py | 28 ++++++++++++++++++++++++----
 1 file changed, 24 insertions(+), 4 deletions(-)

diff --git a/ovsdbapp/tests/unit/test_api.py b/ovsdbapp/tests/unit/test_api.py
index 09b5e775..5dd8c670 100644
--- a/ovsdbapp/tests/unit/test_api.py
+++ b/ovsdbapp/tests/unit/test_api.py
@@ -12,27 +12,46 @@
 #    License for the specific language governing permissions and limitations
 #    under the License.
 
+import sys
+
+import fixtures
 import mock
 import testtools
-import time
 
 from ovsdbapp import api
 from ovsdbapp.tests import base
 
 try:
     import eventlet
+    from eventlet.green import thread
+
+    sleep = eventlet.sleep
 
     def create_thread(executable):
         eventlet.spawn_n(executable)
 
 except ImportError:
     import threading
+    import time
+
+    sleep = time.sleep
 
     def create_thread(executable):
         thread = threading.Thread(target=executable)
         thread.start()
 
 
+class GreenThreadingFixture(fixtures.Fixture):
+    def _setUp(self):
+        if 'eventlet' in sys.modules:
+            self._orig = api.thread.get_ident
+            api.thread.get_ident = thread.get_ident
+            self.addCleanup(self.cleanup)
+
+    def cleanup(self):
+        api.thread.get_ident = self._orig
+
+
 class FakeTransaction(object):
     def __enter__(self):
         return self
@@ -57,6 +76,7 @@ class TransactionTestCase(base.TestCase):
         super(TransactionTestCase, self).setUp()
         self.api = TestingAPI()
         mock.patch.object(FakeTransaction, 'commit').start()
+        self.useFixture(GreenThreadingFixture())
 
     def test_transaction_nested(self):
         with self.api.transaction() as txn1:
@@ -82,12 +102,12 @@ class TransactionTestCase(base.TestCase):
             with self.api.transaction() as txn:
                 shared_resource.append(txn)
                 while len(shared_resource) == 1:
-                    time.sleep(0.1)
+                    sleep(0.1)
             shared_resource.append(0)
 
         def thread2():
             while len(shared_resource) != 1:
-                time.sleep(0.1)
+                sleep(0.1)
             with self.api.transaction() as txn:
                 shared_resource.append(txn)
             shared_resource.append(0)
@@ -96,7 +116,7 @@ class TransactionTestCase(base.TestCase):
         create_thread(thread2)
 
         while len(shared_resource) != 4:
-            time.sleep(0.1)
+            sleep(0.1)
 
         txn1, txn2 = shared_resource[:2]