From df707485c1176b04b2056029e0180eada4f045ab Mon Sep 17 00:00:00 2001 From: Terry Wilson Date: Tue, 21 Jan 2020 09:41:56 -0600 Subject: [PATCH] Log invalid address values in lsp_set_addresses Change-Id: Ib3318ccf1dcb33f5a1ebe15d2e7fdd5631e68786 (cherry picked from commit 575219d54b066d2b5fa0a6ffd30620a139d66211) --- ovsdbapp/schema/ovn_northbound/commands.py | 4 ++-- .../tests/functional/schema/ovn_northbound/test_impl_idl.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ovsdbapp/schema/ovn_northbound/commands.py b/ovsdbapp/schema/ovn_northbound/commands.py index bb06d55d..479d3ff1 100644 --- a/ovsdbapp/schema/ovn_northbound/commands.py +++ b/ovsdbapp/schema/ovn_northbound/commands.py @@ -443,8 +443,8 @@ class LspSetAddressesCommand(cmd.BaseCommand): for addr in addresses: if not self.addr_re.match(addr): raise TypeError( - "address must be router/unknown/dynamic/" - "ethaddr[ ipaddr...]") + "address (%s) must be router/unknown/dynamic/" + "ethaddr[ ipaddr...]" % (addr,)) super(LspSetAddressesCommand, self).__init__(api) self.port = port self.addresses = addresses diff --git a/ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py b/ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py index 7cc18437..d2b19014 100644 --- a/ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py +++ b/ovsdbapp/tests/functional/schema/ovn_northbound/test_impl_idl.py @@ -489,7 +489,7 @@ class TestLspOps(OvnNorthboundTest): def test_lsp_set_addresses_invalid(self): self.assertRaises( TypeError, - self.api.lsp_set_addresses, 'fake', 'invalidaddress') + self.api.lsp_set_addresses, 'fake', ['invalidaddress']) def test_lsp_get_addresses(self): addresses = [