From 6da06edd6242f4029db2d427224b64337ea2217d Mon Sep 17 00:00:00 2001 From: Luigi Toscano Date: Mon, 7 Jan 2019 17:50:41 +0100 Subject: [PATCH] Use the canonical URL for repositories (git.openstack.org) - When the URL refers to cloning or using git repositories, use the cloning URL (https://git.openstack.org//) - When the URL refers to the browsable version of the repository, point to the cgit frontend (https://git.openstack.org/cgit//) Change-Id: Iaeaa153a05aa85b9cf7451ae3c28aec56722222c --- HACKING.rst | 2 +- README.rst | 6 +++--- devstack/README.rst | 2 +- doc/source/multi-policy-validation.rst | 2 +- doc/source/rbac-overview.rst | 4 ++-- patrole_tempest_plugin/policy_authority.py | 2 +- .../api/compute/test_server_misc_policy_actions_rbac.py | 2 +- .../tests/api/identity/v3/test_auth_rbac.py | 2 +- .../api/identity/v3/test_domain_configuration_rbac.py | 2 +- patrole_tempest_plugin/tests/api/network/README.rst | 8 ++++---- 10 files changed, 16 insertions(+), 16 deletions(-) diff --git a/HACKING.rst b/HACKING.rst index 3379292a..cd85d840 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -41,7 +41,7 @@ The following are Patrole's specific Commandments: code that is more maintainable and easier to read - [P104] RBAC `extension test class`_ names must end in 'ExtRbacTest' -.. _extension test class: https://github.com/openstack/patrole/tree/master/patrole_tempest_plugin/tests/api/network#neutron-extension-rbac-tests +.. _extension test class: https://git.openstack.org/cgit/openstack/patrole/plain/patrole_tempest_plugin/tests/api/network/README.rst Supported OpenStack Components ------------------------------ diff --git a/README.rst b/README.rst index 713756a1..dfba71f6 100644 --- a/README.rst +++ b/README.rst @@ -75,8 +75,8 @@ but not all, as its testing scope is confined to policies. .. _Tempest plugin: https://docs.openstack.org/tempest/latest/plugin.html .. _Tempest design principles: https://docs.openstack.org/tempest/latest/overview.html#design-principles .. _policy in code: https://specs.openstack.org/openstack/oslo-specs/specs/newton/policy-in-code.html -.. _Nova repository: https://github.com/openstack/nova/tree/master/nova/policies -.. _Keystone repository: https://github.com/openstack/keystone/tree/master/keystone/common/policies +.. _Nova repository: https://git.openstack.org/cgit/openstack/nova/tree/nova/policies +.. _Keystone repository: https://git.openstack.org/cgit/openstack/keystone/tree/keystone/common/policies Features -------- @@ -174,7 +174,7 @@ the steps outlined therein. Afterward, proceed with the steps below. the Patrole repository. To configure Patrole's logging, see the `Patrole Configuration Guide `_. -.. _Tempest: https://github.com/openstack/tempest +.. _Tempest: https://git.openstack.org/cgit/openstack/tempest .. _Tempest_quickstart: https://docs.openstack.org/tempest/latest/overview.html#quickstart .. _tempest_run: https://docs.openstack.org/tempest/latest/run.html .. _testr: https://testrepository.readthedocs.org/en/latest/MANUAL.html diff --git a/devstack/README.rst b/devstack/README.rst index 053afd4f..490f8333 100644 --- a/devstack/README.rst +++ b/devstack/README.rst @@ -22,4 +22,4 @@ Enabling in Devstack 3. Run ``stack.sh`` found in the DevStack repo. -.. _README file: https://github.com/openstack-dev/devstack/blob/master/README.rst +.. _README file: https://git.openstack.org/cgit/openstack-dev/devstack/plain/README.rst diff --git a/doc/source/multi-policy-validation.rst b/doc/source/multi-policy-validation.rst index d38b31e5..576fd68e 100644 --- a/doc/source/multi-policy-validation.rst +++ b/doc/source/multi-policy-validation.rst @@ -20,7 +20,7 @@ information about Patrole's RBAC validation work flow, reference Multi-policy support allows Patrole to more accurately offer RBAC tests for API endpoints that enforce multiple policy actions. -.. _this spec: https://github.com/openstack/qa-specs/blob/master/specs/patrole/rbac-testing-multiple-policies.rst +.. _this spec: http://specs.openstack.org/openstack/qa-specs/specs/patrole/rbac-testing-multiple-policies.html Scope ----- diff --git a/doc/source/rbac-overview.rst b/doc/source/rbac-overview.rst index cc47f757..747eab8c 100644 --- a/doc/source/rbac-overview.rst +++ b/doc/source/rbac-overview.rst @@ -271,8 +271,8 @@ related to RBAC in Patrole. Related term: :term:`hard authorization`. -.. _Nova repository: https://github.com/openstack/nova/tree/master/nova/policies -.. _Keystone repository: https://github.com/openstack/keystone/tree/master/keystone/common/policies +.. _Nova repository: https://git.openstack.org/cgit/openstack/nova/tree/nova/policies +.. _Keystone repository: https://git.openstack.org/cgit/openstack/keystone/tree/keystone/common/policies .. _governance goal: https://governance.openstack.org/tc/goals/queens/policy-in-code.html .. _scope types: https://docs.openstack.org/keystone/latest/admin/identity-tokens.html#authorization-scopes .. _policy.yaml: https://docs.openstack.org/ocata/config-reference/policy-yaml-file.html diff --git a/patrole_tempest_plugin/policy_authority.py b/patrole_tempest_plugin/policy_authority.py index e0a26a3f..259a0565 100644 --- a/patrole_tempest_plugin/policy_authority.py +++ b/patrole_tempest_plugin/policy_authority.py @@ -266,7 +266,7 @@ class PolicyAuthority(RbacAuthority): # than hard-coding it to True. is_admin_project cannot be determined # from the role, but rather from project and domain names. For more # information, see: - # https://github.com/openstack/keystone/blob/37ce5417418f8acbd27f3dacb70c605b0fe48301/keystone/token/providers/common.py#L150 + # https://git.openstack.org/cgit/openstack/keystone/tree/keystone/token/providers/common.py?id=37ce5417418f8acbd27f3dacb70c605b0fe48301#n150 access_data['is_admin_project'] = True class Object(object): diff --git a/patrole_tempest_plugin/tests/api/compute/test_server_misc_policy_actions_rbac.py b/patrole_tempest_plugin/tests/api/compute/test_server_misc_policy_actions_rbac.py index 64e1300a..5e389708 100644 --- a/patrole_tempest_plugin/tests/api/compute/test_server_misc_policy_actions_rbac.py +++ b/patrole_tempest_plugin/tests/api/compute/test_server_misc_policy_actions_rbac.py @@ -505,7 +505,7 @@ class MiscPolicyActionsRbacTest(rbac_base.BaseV2ComputeRbacTest): TODO(felipemonteiro): Once multiple policy testing is supported, this test should also check for additional policies mentioned here: - https://github.com/openstack/nova/blob/master/nova/policies/server_usage.py + https://git.openstack.org/cgit/openstack/nova/tree/nova/policies/server_usage.py?h=17.0.0 """ expected_attrs = ('OS-SRV-USG:launched_at', 'OS-SRV-USG:terminated_at') diff --git a/patrole_tempest_plugin/tests/api/identity/v3/test_auth_rbac.py b/patrole_tempest_plugin/tests/api/identity/v3/test_auth_rbac.py index a63192f3..a8cc767a 100644 --- a/patrole_tempest_plugin/tests/api/identity/v3/test_auth_rbac.py +++ b/patrole_tempest_plugin/tests/api/identity/v3/test_auth_rbac.py @@ -23,7 +23,7 @@ class IdentityAuthV3RbacTest(rbac_base.BaseIdentityV3RbacTest): """Tests the APIs that enforce the auth policy actions. For more information about the auth policy actions, see: - https://github.com/openstack/keystone/blob/master/keystone/common/policies/auth.py + https://git.openstack.org/cgit/openstack/keystone/tree/keystone/common/policies/auth.py """ # TODO(felipemonteiro): Add tests for identity:get_auth_catalog diff --git a/patrole_tempest_plugin/tests/api/identity/v3/test_domain_configuration_rbac.py b/patrole_tempest_plugin/tests/api/identity/v3/test_domain_configuration_rbac.py index 4fa39379..35154ebd 100644 --- a/patrole_tempest_plugin/tests/api/identity/v3/test_domain_configuration_rbac.py +++ b/patrole_tempest_plugin/tests/api/identity/v3/test_domain_configuration_rbac.py @@ -28,7 +28,7 @@ class DomainConfigurationV3RbacTest(rbac_base.BaseIdentityV3RbacTest): """RBAC tests for domain configuration client. Provides coverage for the following policy actions: - https://github.com/openstack/keystone/blob/master/keystone/common/policies/domain_config.py + https://git.openstack.org/cgit/openstack/keystone/tree/keystone/common/policies/domain_config.py """ identity = {"driver": "ldap"} diff --git a/patrole_tempest_plugin/tests/api/network/README.rst b/patrole_tempest_plugin/tests/api/network/README.rst index 352af8ac..6eaae080 100644 --- a/patrole_tempest_plugin/tests/api/network/README.rst +++ b/patrole_tempest_plugin/tests/api/network/README.rst @@ -41,7 +41,7 @@ gracefully skipped. possible (such as ``neutron_tempest_plugin.api.clients`` for the service clients) because the module is not a `stable interface`_. -.. _policy.json file: https://github.com/openstack/neutron/blob/master/etc/policy.json -.. _Zuul jobs: https://github.com/openstack/patrole/blob/master/.zuul.yaml -.. _neutron-tempest-plugin: https://github.com/openstack/neutron-tempest-plugin -.. _stable interface: https://github.com/openstack/neutron-tempest-plugin/tree/master/neutron_tempest_plugin#warning +.. _policy.json file: https://git.openstack.org/cgit/openstack/neutron/tree/etc/policy.json?h=12.0.0 +.. _Zuul jobs: https://git.openstack.org/cgit/openstack/patrole/tree/.zuul.yaml +.. _neutron-tempest-plugin: https://git.openstack.org/cgit/openstack/neutron-tempest-plugin +.. _stable interface: https://git.openstack.org/cgit/openstack/neutron-tempest-plugin/plain/neutron_tempest_plugin/README.rst