openstack
/
patrole
Code Issues Proposed changes

Add waiters after creating volume transfer for related tests 

This patch set adds waiters for better test robustness following
creation of volume transfers. This is consistent with
Tempest behavior [0].

[0] 4e6b46e196/tempest/api/volume/test_volume_transfers.py (L51)

Change-Id: Ifb8ab83872b203e1b2a200e5bbefc2fd3f624974
This commit is contained in:
Felipe Monteiro 2018-07-27 21:36:13 +01:00
parent 2a21633949
commit fcd6fcf33c
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
patrole_tempest_plugin/tests/api/volume/test_volume_transfers_rbac.py
View File

@ -54,12 +54,17 @@ class VolumesTransfersV3RbacTest(rbac_base.BaseVolumeRbacTest):
def test_create_volume_transfer(self):
with self.rbac_utils.override_role(self):
self._create_transfer()
waiters.wait_for_volume_resource_status(
self.volumes_client, self.volume['id'], 'awaiting-transfer')
@rbac_rule_validation.action(service="cinder",
rule="volume:get_transfer")
@decorators.idempotent_id('7a0925d3-ed97-4c25-8299-e5cdabe2eb55')
def test_get_volume_transfer(self):
transfer = self._create_transfer()
waiters.wait_for_volume_resource_status(
self.volumes_client, self.volume['id'], 'awaiting-transfer')
with self.rbac_utils.override_role(self):
self.transfers_client.show_volume_transfer(transfer['id'])
@ -82,15 +87,23 @@ class VolumesTransfersV3RbacTest(rbac_base.BaseVolumeRbacTest):
@decorators.idempotent_id('987f2a11-d657-4984-a6c9-28f06c1cd014')
def test_accept_volume_transfer(self):
transfer = self._create_transfer()
waiters.wait_for_volume_resource_status(
self.volumes_client, self.volume['id'], 'awaiting-transfer')
with self.rbac_utils.override_role(self):
self.transfers_client.accept_volume_transfer(
transfer['id'], auth_key=transfer['auth_key'])
waiters.wait_for_volume_resource_status(self.volumes_client,
self.volume['id'], 'available')
@rbac_rule_validation.action(service="cinder",
rule="volume:delete_transfer")
@decorators.idempotent_id('4672187e-7fff-454b-832a-5c8865dda868')
def test_delete_volume_transfer(self):
transfer = self._create_transfer()
waiters.wait_for_volume_resource_status(
self.volumes_client, self.volume['id'], 'awaiting-transfer')
with self.rbac_utils.override_role(self):
self.transfers_client.delete_volume_transfer(transfer['id'])
waiters.wait_for_volume_resource_status(