openstack
/
paunch
Code Issues Proposed changes

Exit 1 if a container fails and return the error 

When a container's volumes failed validation, paunch still exited 0.
This caused the deployment to continue running even though not all
containers had been started.

This patch changes the rc to 1 when a container's volumes fail
validation and the container can't be started. The error message is also
returned in stderr so that it's available to the paunch ansible module
and will be seen in the deployment output.

Depends-On: I1f062b8b9f936e6fbf2febf64244e91b59b8ba1b
Change-Id: I67860a79572c0ff4dcaca9ec9597c41f56792fca
Closes-Bug: #1855444
This commit is contained in:
James Slagle 2019-12-06 08:37:40 -05:00 committed by Emilien Macchi
parent 14fa098fcb
commit 3ab0936c03
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
paunch/builder/base.py
View File

@ -49,6 +49,7 @@ class BaseBuilder(object):
deploy_status_code = 0
key_fltr = lambda k: self.config[k].get('start_order', 0)
failed_containers = []
container_names = self.runner.container_names(self.config_id)
desired_names = set([cn[-1] for cn in container_names])
@ -119,6 +120,7 @@ class BaseBuilder(object):
if not validations_passed:
self.log.debug('Validations failed. Skipping container: %s' %
container)
failed_containers.append(container)
continue
(cmd_stdout, cmd_stderr, returncode) = self.runner.execute(
@ -150,6 +152,18 @@ class BaseBuilder(object):
container=container_name,
cconfig=cconfig,
log=self.log)
if failed_containers:
message = (
"The following containers failed validations "
"and were not started: {}".format(
', '.join(failed_containers)))
self.log.error(message)
# The message is also added to stderr so that it's returned and
# logged by the paunch module for ansible
stderr.append(message)
deploy_status_code = 1
return stdout, stderr, deploy_status_code
def delete_missing_and_updated(self):