gerrit/acl : remove deprecated copy conditions

The copy conditions here have been replaced by the "copyCondition"
query tag.  This updates the deprecated values to a new query which
does the same thing -- i.e. this should be a noop.

Mostly these are setup to have votes on labels that should be copied
on a no code change/trivial rebase, and if they're -2/+2 (i.e. max
votes are sticky).  To be exact the group of

 copyallScoresIfNoCodeChange = true
 copyAllScoresOnTrivialRebase = true
 copyMaxScore = true
 copyMinScore = true

becomes

 changekind:NO_CODE_CHANGE or changekind:TRIVIAL_REBASE \
  or is:MAX or is:MIN

Note all but ocatvia.conf, octavia-dashboard, octavia-lib, and
python-octaviaclient are copying -2/+2 votes; I feel like this is
probably a bug but I have modified these 4 projects to maintain the
same behaviour of not copying the votes.

A small number of projects copy any vote; glance.config,
kayobe.config, kolla.config, nova-specs.config, nova.config,
os-vif.config, placement.config, python-novaclient.config -- they are
replaced with is:ANY.

The old conditions have been deprecated since gerrit 3.5 [1].
Although the old conditions have not been removed yet, this will help
as we think about also changing these to submission requirements for
Gerrit 3.7.

[1] https://gerrit.googlesource.com/gerrit/+/c429ff33d944272b1f4da9f84f904f6403919ea3

Change-Id: Id13fdf588d07c1fec73978e7a69f1d9097989696
This commit is contained in:
Ian Wienand 2022-12-16 14:31:41 +11:00
parent 2d52441bfa
commit 6349f18d40
No known key found for this signature in database
89 changed files with 97 additions and 305 deletions

View File

@ -5,7 +5,7 @@ label-Rollcall-Vote = -1..+1 group infra-council
label-Workflow = -1..+1 group infra-ptl
[label "Code-Review"]
copyAllScoresOnTrivialRebase = true
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
value = -2 Unused -2
@ -15,7 +15,7 @@ value = +1 Looks good to me
value = +2 Unused +2
[label "Rollcall-Vote"]
copyAllScoresOnTrivialRebase = true
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = AnyWithBlock
value = -2 Veto

View File

@ -12,7 +12,7 @@ label-Workflow = -1..+1 group transparency-committee-chair
createSignedTag = group transparency-committee-chair
[label "Code-Review"]
copyAllScoresOnTrivialRebase = true
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
value = -2 Unused -2
@ -22,7 +22,7 @@ value = +1 Looks good to me
value = +2 Unused +2
[label "Rollcall-Vote"]
copyAllScoresOnTrivialRebase = true
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
value = -1 No

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -8,10 +8,7 @@ label-Review-Priority = -1..+2 group blazar-core
label-Workflow = -1..+1 group blazar-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -18,10 +18,7 @@ label-Workflow = -1..+1 group charms-core
createSignedTag = group charms-release
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -18,10 +18,7 @@ label-Workflow = -1..+1 group charms-trilio-core
createSignedTag = group charms-release
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -18,10 +18,7 @@ label-Workflow = -1..+1 group charms-vault-core
createSignedTag = group charms-release
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Workflow = -1..+1 group charms-core
createSignedTag = group charms-release
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -8,10 +8,7 @@ label-Review-Priority = -1..+2 group cinder-tempest-plugin-core
label-Workflow = -1..+1 group cinder-tempest-plugin-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -23,10 +23,7 @@ label-Workflow = -1..+1 group cinder-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -12,10 +12,7 @@ label-Workflow = -1..+1 group cloudkitty-core
label-Workflow = -1..+1 group horizon-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -8,10 +8,7 @@ label-Review-Priority = -1..+2 group cloudkitty-core
label-Workflow = -1..+1 group cloudkitty-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -30,10 +30,7 @@ label-Workflow = -1..+1 group horizon-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -9,10 +9,7 @@ label-Workflow = -1..+1 group designate-core
toggleWipState = group designate-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -10,10 +10,7 @@ label-Workflow = -1..+1 group designate-tempest-plugin-core
toggleWipState = group designate-tempest-plugin-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -25,10 +25,7 @@ label-Workflow = -1..+1 group designate-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -9,10 +9,7 @@ label-Verified = -1..+1 group devstack-ci
label-Workflow = -1..+1 group devstack-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -8,10 +8,7 @@ label-Review-Priority = -1..+2 group glance-tempest-plugin-core
label-Workflow = -1..+1 group glance-tempest-plugin-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -25,7 +25,7 @@ label-Workflow = -1..+1 group glance-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAnyScore = true
copyCondition = is:ANY
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -28,10 +28,7 @@ label-Workflow = -1..+1 group glance-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -16,7 +16,7 @@ label-Workflow = -1..+1 group tech-committee-chair
createSignedTag = group tech-committee-chair
[label "Code-Review"]
copyAllScoresOnTrivialRebase = true
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
value = -2 Unused -2
@ -26,7 +26,7 @@ value = +1 Looks good to me
value = +2 Unused +2
[label "Rollcall-Vote"]
copyAllScoresOnTrivialRebase = true
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
value = -1 No

View File

@ -8,10 +8,7 @@ label-Review-Priority = -1..+2 group greande-core
label-Workflow = -1..+1 group grenade-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -24,10 +24,7 @@ label-Workflow = -1..+1 group horizon-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Release Freeze

View File

@ -50,10 +50,7 @@ toggleWipState = group stable-maint-core
createSignedTag = group ironic-release
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -1 Do Not Backport

View File

@ -12,7 +12,7 @@ label-Workflow = -1..+1 group kayobe-core
toggleWipState = group kayobe-core
[label "Backport-Candidate"]
copyAnyScore = true
copyCondition = is:ANY
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport
@ -22,7 +22,7 @@ value = +1 Proposed Backport
value = +2 Should Backport
[label "Review-Priority"]
copyAnyScore = true
copyCondition = is:ANY
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -12,7 +12,7 @@ label-Workflow = -1..+1 group kolla-core
toggleWipState = group kolla-core
[label "Backport-Candidate"]
copyAnyScore = true
copyCondition = is:ANY
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport
@ -22,7 +22,7 @@ value = +1 Proposed Backport
value = +2 Should Backport
[label "Review-Priority"]
copyAnyScore = true
copyCondition = is:ANY
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -9,10 +9,7 @@ label-Code-Review = -2..+2 group magnum-ui-core
label-Workflow = -1..+1 group magnum-ui-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -9,10 +9,7 @@ label-Code-Review = -2..+2 group magnum-core
label-Workflow = -1..+1 group magnum-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -11,7 +11,7 @@ label-Workflow = -1..+1 group horizon-core
label-Workflow = -1..+1 group monasca-core
[label "Review-Priority"]
copyMaxScore = true
copyCondition = is:MAX
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -8,7 +8,7 @@ label-Review-Priority = -1..+2 group monasca-core
label-Workflow = -1..+1 group monasca-core
[label "Review-Priority"]
copyMaxScore = true
copyCondition = is:MAX
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -27,10 +27,7 @@ label-Workflow = -1..+1 group neutron-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -27,10 +27,7 @@ label-Workflow = -1..+1 group neutron-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -27,10 +27,7 @@ label-Workflow = -1..+1 group neutron-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -27,10 +27,7 @@ label-Workflow = -1..+1 group neutron-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -31,10 +31,7 @@ label-Workflow = -1..+1 group neutron-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -24,10 +24,7 @@ label-Workflow = -1..+1 group horizon-stable-maint
label-Workflow = -1..+1 group neutron-stable-maint
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -28,10 +28,7 @@ label-Workflow = -1..+1 group neutron-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -28,10 +28,7 @@ label-Workflow = -1..+1 group neutron-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -8,10 +8,7 @@ label-Review-Priority = -1..+2 group neutron-specs-core
label-Workflow = -1..+1 group neutron-drivers-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -24,10 +24,7 @@ label-Workflow = -1..+1 group horizon-stable-maint
label-Workflow = -1..+1 group neutron-stable-maint
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -31,10 +31,7 @@ label-Workflow = -1..+1 group neutron-vpnaas-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -28,10 +28,7 @@ label-Workflow = -1..+1 group neutron-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -9,7 +9,7 @@ label-Review-Priority = +0..+2 group nova-specs-core
label-Workflow = -1..+1 group nova-specs-core
[label "Review-Priority"]
copyAnyScore = true
copyCondition = is:ANY
defaultValue = 0
function = NoOp
value = 0 Default Priority

View File

@ -28,7 +28,7 @@ label-Workflow = -1..+1 group nova-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAnyScore = true
copyCondition = is:ANY
defaultValue = 0
function = NoOp
value = 0 Default Priority

View File

@ -26,8 +26,7 @@ label-Workflow = -1..+1 group octavia-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -26,8 +26,7 @@ label-Workflow = -1..+1 group octavia-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -29,8 +29,7 @@ label-Workflow = -1..+1 group octavia-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -8,10 +8,7 @@ label-Code-Review = -2..+2 group openstack-ansible-core
label-Workflow = -1..+1 group openstack-ansible-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -1 Not A Backport Candidate

View File

@ -30,7 +30,7 @@ label-Workflow = -1..+1 group os-vif-core
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAnyScore = true
copyCondition = is:ANY
defaultValue = 0
function = NoOp
value = 0 Default Priority

View File

@ -12,10 +12,7 @@ label-Code-Review = -2..+2 group oslo-cache-core
label-Workflow = -1..+1 group oslo-cache-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -20,10 +20,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -15,10 +15,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -9,10 +9,7 @@ label-Code-Review = -2..+2 group osprofiler-core
label-Workflow = -1..+1 group osprofiler-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -25,10 +25,7 @@ label-Workflow = -1..+1 group ovn-octavia-provider-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -8,10 +8,7 @@ label-Review-Priority = -1..+2 group patrole-core
label-Workflow = -1..+1 group patrole-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Release Freeze

View File

@ -28,7 +28,7 @@ label-Workflow = -1..+1 group placement-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAnyScore = true
copyCondition = is:ANY
defaultValue = 0
function = NoOp
value = 0 Default Priority

View File

@ -24,10 +24,7 @@ label-Workflow = -1..+1 group designate-milestone
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -27,7 +27,7 @@ label-Workflow = -1..+1 group nova-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Review-Priority"]
copyAnyScore = true
copyCondition = is:ANY
defaultValue = 0
function = NoOp
value = 0 Default Priority

View File

@ -26,8 +26,7 @@ label-Workflow = -1..+1 group octavia-stable-maint
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -8,10 +8,7 @@ label-Review-Priority = -1..+2 group rbd-iscsi-client-core
label-Workflow = -1..+1 group rbd-iscsi-client-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -8,7 +8,7 @@ label-PTL-Approved = +0..+1 group Continuous Integration Tools
label-Workflow = -1..+1 group releases-core
[label "PTL-Approved"]
copyAllScoresOnTrivialRebase = true
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
value = 0 Abstain

View File

@ -8,7 +8,7 @@ label-PTL-Approved = +0..+1 group Continuous Integration Tools
label-Workflow = -1..+1 group releases-core
[label "PTL-Approved"]
copyAllScoresOnTrivialRebase = true
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = AnyWithBlock
value = -1 Block

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -9,10 +9,7 @@ label-Verified = -1..+1 group tempest-ci
label-Workflow = -1..+1 group tempest-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Release Freeze

View File

@ -14,10 +14,7 @@ label-Code-Review = -2..+2 group stable-maint-core
label-Workflow = -1..+1 group stable-maint-core
[label "Backport-Candidate"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = NoBlock
value = -2 Do Not Backport

View File

@ -10,10 +10,7 @@ label-Workflow = -1..+1 group tripleo-ci-core
toggleWipState = group tripleo-ci-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -8,10 +8,7 @@ label-Review-Priority = -1..+2 group zaqar-ui-core
label-Workflow = -1..+1 group zaqar-ui-core
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -23,10 +23,7 @@ label-Workflow = -1..+1 group stable-maint-core
label-Workflow = -1..+1 group zaqar-stable-maint
[label "Review-Priority"]
copyAllScoresIfNoCodeChange = true
copyAllScoresOnTrivialRebase = true
copyMaxScore = true
copyMinScore = true
copyCondition = changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR is:MAX OR is:MIN
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -12,7 +12,7 @@ label-Workflow = -1..+1 group stx-tech-steering-committee-secretary
createSignedTag = group stx-tech-steering-committee-secretary
[label "Code-Review"]
copyAllScoresOnTrivialRebase = true
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
value = -2 Unused -2
@ -22,7 +22,7 @@ value = +1 Looks good to me
value = +2 Unused +2
[label "Rollcall-Vote"]
copyAllScoresOnTrivialRebase = true
copyCondition = changekind:TRIVIAL_REBASE
defaultValue = 0
function = NoOp
value = -1 No

View File

@ -5,7 +5,7 @@ label-Review-Priority = -1..+2 group monasca-core
label-Workflow = -1..+1 group monasca-core
[label "Review-Priority"]
copyMaxScore = true
copyCondition = is:MAX
defaultValue = 0
function = AnyWithBlock
value = -1 Branch Freeze

View File

@ -58,13 +58,9 @@ out = ''
valid_keys = {'abandon',
'access',
'copyAllScoresIfNoCodeChange',
'copyAllScoresOnTrivialRebase',
'copyAnyScore',
'copyMaxScore',
'copyMinScore',
'create',
'createSignedTag',
'copyCondition',
'defaultValue',
'delete',
'editHashtags',
@ -114,7 +110,8 @@ for line in aclfd:
# Check for valid keys
key = line.split('=')[0].strip()
if key not in valid_keys:
raise Exception('Unrecognized key in line: "%s"' % line)
raise Exception('(%s) Unrecognized key "%s" in line: "%s"'
% (aclfile, key, line))
# WTF
else:
raise Exception('Unrecognized line: "%s"' % line)