From d41dfcd16f77de196af7d8a17673b4718fac9257 Mon Sep 17 00:00:00 2001 From: Sean Mooney Date: Thu, 22 Apr 2021 11:07:24 +0100 Subject: [PATCH] Add review priority label to nova deliverables This change adds a Review Priority label to all nova deliverables currently under acl control in the project config repo. The ability set the new label is granted only to the core and stable core teams for the updated repos. Change-Id: I2fd7a6387d2f50eeeb8cef513df19b5696cce55b --- gerrit/acls/openstack/nova-specs.config | 8 ++++++++ gerrit/acls/openstack/nova.config | 9 +++++++++ gerrit/acls/openstack/os-vif.config | 9 +++++++++ gerrit/acls/openstack/placement.config | 9 +++++++++ gerrit/acls/openstack/python-novaclient.config | 9 +++++++++ tools/normalize_acl.py | 1 + 6 files changed, 45 insertions(+) diff --git a/gerrit/acls/openstack/nova-specs.config b/gerrit/acls/openstack/nova-specs.config index 2848b3f284..3c8ed84f34 100644 --- a/gerrit/acls/openstack/nova-specs.config +++ b/gerrit/acls/openstack/nova-specs.config @@ -1,8 +1,16 @@ [access "refs/heads/*"] abandon = group nova-specs-core label-Code-Review = -2..+2 group nova-specs-core +label-Review-Priority = +0..+1 group nova-specs-core label-Workflow = -1..+1 group nova-specs-core +[label "Review-Priority"] +copyAnyScore = true +defaultValue = 0 +function = NoOp +value = 0 Default Priority +value = +1 High Priority + [receive] requireChangeId = true requireContributorAgreement = true diff --git a/gerrit/acls/openstack/nova.config b/gerrit/acls/openstack/nova.config index 85df923bf8..501755e0f7 100644 --- a/gerrit/acls/openstack/nova.config +++ b/gerrit/acls/openstack/nova.config @@ -1,6 +1,7 @@ [access "refs/heads/*"] abandon = group nova-core label-Code-Review = -2..+2 group nova-core +label-Review-Priority = +0..+1 group nova-core label-Verified = -1..+1 group nova-ci label-Workflow = -1..+1 group nova-core @@ -14,11 +15,19 @@ label-Code-Review = -2..+2 group Project Bootstrappers label-Code-Review = -2..+2 group nova-stable-maint label-Code-Review = -2..+2 group stable-maint-core label-Code-Review = -1..+1 group Registered Users +label-Review-Priority = +0..+1 group nova-stable-maint label-Workflow = -1..+0 group Change Owner label-Workflow = -1..+1 group Project Bootstrappers label-Workflow = -1..+1 group nova-stable-maint label-Workflow = -1..+1 group stable-maint-core +[label "Review-Priority"] +copyAnyScore = true +defaultValue = 0 +function = NoOp +value = 0 Default Priority +value = +1 High Priority + [receive] requireChangeId = true requireContributorAgreement = true diff --git a/gerrit/acls/openstack/os-vif.config b/gerrit/acls/openstack/os-vif.config index e8b4178b8f..25299cac34 100644 --- a/gerrit/acls/openstack/os-vif.config +++ b/gerrit/acls/openstack/os-vif.config @@ -1,6 +1,7 @@ [access "refs/heads/*"] abandon = group os-vif-core label-Code-Review = -2..+2 group os-vif-core +label-Review-Priority = +0..+1 group os-vif-core label-Workflow = -1..+1 group os-vif-core [access "refs/heads/stable/*"] @@ -13,11 +14,19 @@ label-Code-Review = -2..+2 group Project Bootstrappers label-Code-Review = -2..+2 group nova-stable-maint label-Code-Review = -2..+2 group stable-maint-core label-Code-Review = -1..+1 group Registered Users +label-Review-Priority = +0..+1 group nova-stable-maint label-Workflow = -1..+0 group Change Owner label-Workflow = -1..+1 group Project Bootstrappers label-Workflow = -1..+1 group nova-stable-maint label-Workflow = -1..+1 group stable-maint-core +[label "Review-Priority"] +copyAnyScore = true +defaultValue = 0 +function = NoOp +value = 0 Default Priority +value = +1 High Priority + [receive] requireChangeId = true requireContributorAgreement = true diff --git a/gerrit/acls/openstack/placement.config b/gerrit/acls/openstack/placement.config index b7a030f5bf..ee75c14369 100644 --- a/gerrit/acls/openstack/placement.config +++ b/gerrit/acls/openstack/placement.config @@ -1,6 +1,7 @@ [access "refs/heads/*"] abandon = group placement-core label-Code-Review = -2..+2 group placement-core +label-Review-Priority = +0..+1 group placement-core label-Verified = -1..+1 group placement-ci label-Workflow = -1..+1 group placement-core @@ -14,11 +15,19 @@ label-Code-Review = -2..+2 group Project Bootstrappers label-Code-Review = -2..+2 group placement-stable-maint label-Code-Review = -2..+2 group stable-maint-core label-Code-Review = -1..+1 group Registered Users +label-Review-Priority = +0..+1 group placement-stable-maint label-Workflow = -1..+0 group Change Owner label-Workflow = -1..+1 group Project Bootstrappers label-Workflow = -1..+1 group placement-stable-maint label-Workflow = -1..+1 group stable-maint-core +[label "Review-Priority"] +copyAnyScore = true +defaultValue = 0 +function = NoOp +value = 0 Default Priority +value = +1 High Priority + [receive] requireChangeId = true requireContributorAgreement = true diff --git a/gerrit/acls/openstack/python-novaclient.config b/gerrit/acls/openstack/python-novaclient.config index 4f22e50364..25a7250158 100644 --- a/gerrit/acls/openstack/python-novaclient.config +++ b/gerrit/acls/openstack/python-novaclient.config @@ -1,6 +1,7 @@ [access "refs/heads/*"] abandon = group python-novaclient-core label-Code-Review = -2..+2 group python-novaclient-core +label-Review-Priority = +0..+1 group python-novaclient-core label-Workflow = -1..+1 group python-novaclient-core [access "refs/heads/stable/*"] @@ -13,11 +14,19 @@ label-Code-Review = -2..+2 group Project Bootstrappers label-Code-Review = -2..+2 group nova-stable-maint label-Code-Review = -2..+2 group stable-maint-core label-Code-Review = -1..+1 group Registered Users +label-Review-Priority = +0..+1 group nova-stable-maint label-Workflow = -1..+0 group Change Owner label-Workflow = -1..+1 group Project Bootstrappers label-Workflow = -1..+1 group nova-stable-maint label-Workflow = -1..+1 group stable-maint-core +[label "Review-Priority"] +copyAnyScore = true +defaultValue = 0 +function = NoOp +value = 0 Default Priority +value = +1 High Priority + [receive] requireChangeId = true requireContributorAgreement = true diff --git a/tools/normalize_acl.py b/tools/normalize_acl.py index e2d7a3cdf0..f4acf3f6d0 100755 --- a/tools/normalize_acl.py +++ b/tools/normalize_acl.py @@ -60,6 +60,7 @@ valid_keys = {'abandon', 'access', 'copyAllScoresIfNoCodeChange', 'copyAllScoresOnTrivialRebase', + 'copyAnyScore', 'copyMaxScore', 'copyMinScore', 'create',