Update patch set 7
Patch Set 7: Code-Review-1 (7 comments) Patch-set: 7 Reviewer: Gerrit User 17685 <17685@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1, 12b4bbdbe9a0115bfe731c3408c3bea4e332acf4
This commit is contained in:
Gerrit User 17685
Gerrit Code Review
parent
4f8c753c85
commit
b8c45a63eb
|
|
@ -34,6 +34,40 @@
|
|||
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "1854e631_8ded4f47",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 17685
|
||||
},
|
||||
"writtenOn": "2024-01-19T15:30:41Z",
|
||||
"side": 1,
|
||||
"message": "Thanks Brian for working on this! This mostly looks OK to me. I have two comments that needs some further update i think, see them inline.",
|
||||
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "1a753187_3418b87e",
|
||||
"filename": "doc/source/stable-branches.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 32,
|
||||
"author": {
|
||||
"id": 17685
|
||||
},
|
||||
"writtenOn": "2024-01-19T15:30:41Z",
|
||||
"side": 1,
|
||||
"message": "✔ (though from 2023.1 Antelope onwards, AFAIR, but yes, this is OK)",
|
||||
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -51,6 +85,46 @@
|
|||
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "0a22d25a_533ea803",
|
||||
"filename": "doc/source/stable-branches.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 87,
|
||||
"author": {
|
||||
"id": 17685
|
||||
},
|
||||
"writtenOn": "2024-01-19T15:30:41Z",
|
||||
"side": 1,
|
||||
"message": "✔",
|
||||
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "f2cf1611_ad900a6c",
|
||||
"filename": "doc/source/stable-branches.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 155,
|
||||
"author": {
|
||||
"id": 17685
|
||||
},
|
||||
"writtenOn": "2024-01-19T15:30:41Z",
|
||||
"side": 1,
|
||||
"message": "This tag was used for tempest and tempest plugins in the past. And I think this is not even necessary and gives some extra work to the RelMgt team. Nevertheless, it may have some value.... anyway, can we cut this and discuss this in a follow up patch instead?",
|
||||
"range": {
|
||||
"startLine": 151,
|
||||
"startChar": 0,
|
||||
"endLine": 155,
|
||||
"endChar": 71
|
||||
},
|
||||
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
|
@ -90,6 +164,57 @@
|
|||
"message": "this wording sounds a bit odd to me\n\n\"... and there is no guarantee about\"?",
|
||||
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "82311596_146c6727",
|
||||
"filename": "doc/source/stable-branches.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 177,
|
||||
"author": {
|
||||
"id": 17685
|
||||
},
|
||||
"writtenOn": "2024-01-19T15:30:41Z",
|
||||
"side": 1,
|
||||
"message": "yepp, here is the $series-last tag as I mentioned above.",
|
||||
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "d1559a55_5aff4d43",
|
||||
"filename": "doc/source/stable-branches.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 347,
|
||||
"author": {
|
||||
"id": 17685
|
||||
},
|
||||
"writtenOn": "2024-01-19T15:30:41Z",
|
||||
"side": 1,
|
||||
"message": ":D ok, i get it... :D\n\nanyway, we already pushed away all responsibility from project teams regarding these branches, so I\u0027d rather simply say something like this instead:\n\nInstead, there is a global ``openstack-unmaintained-core`` team that have access rights to maintain the CI running on Unmaintained branches, and to merge appropriate changes into Unmaintained branches.",
|
||||
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "cc205537_2c772771",
|
||||
"filename": "doc/source/stable-branches.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 356,
|
||||
"author": {
|
||||
"id": 17685
|
||||
},
|
||||
"writtenOn": "2024-01-19T15:30:41Z",
|
||||
"side": 1,
|
||||
"message": "✔",
|
||||
"revId": "0f755291340a7b8515df18974095d61dca2d7c82",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue