openstack
/
project-team-guide
Code Issues Proposed changes
project-team-guide/0cbbb407a9e4e80ab9657d00fe1...

245 lines
8.9 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "11522cfd_7cdba920",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 5314
},
"writtenOn": "2024-01-10T23:22:51Z",
"side": 1,
"message": "This update is supposed to capture https://review.opendev.org/c/openstack/releases/+/904862 ... but see question inline.",
"revId": "0cbbb407a9e4e80ab9657d00fe1f78baf3f76046",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9c004c9c_31942903",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 17685
},
"writtenOn": "2024-01-11T10:31:08Z",
"side": 1,
"message": "Thanks Brian, in general this looks good to me.",
"revId": "0cbbb407a9e4e80ab9657d00fe1f78baf3f76046",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c51c07aa_d12a78d0",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 5314
},
"writtenOn": "2024-01-11T21:48:38Z",
"side": 1,
"message": "Thanks for the comments Elod \u0026 Jens, I\u0027ll push a revision.",
"revId": "0cbbb407a9e4e80ab9657d00fe1f78baf3f76046",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c31f2bd9_76f3d440",
"filename": "doc/source/repository.rst",
"patchSetId": 1
},
"lineNbr": 148,
"author": {
"id": 5314
},
"writtenOn": "2024-01-10T23:22:51Z",
"side": 1,
"message": "I\u0027m unclear about what this is saying. Are we supposed to completely remove the yaml file for whatever cycle master development corresponds to, and then update each of the releaseable stable branches yaml files with the \u0027retired\u0027 flag? Or is my Step 3 at line 209 below incorrect, and instead of removing the yaml file, we should just add the \u0027retired\u0027 flag? (Or some combination of the two?)",
"range": {
"startLine": 147,
"startChar": 0,
"endLine": 148,
"endChar": 63
},
"revId": "0cbbb407a9e4e80ab9657d00fe1f78baf3f76046",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c31383cf_4519a174",
"filename": "doc/source/repository.rst",
"patchSetId": 1
},
"lineNbr": 148,
"author": {
"id": 11904
},
"writtenOn": "2024-01-11T06:57:42Z",
"side": 1,
"message": "Here is a fairly recent example of another retired project: https://review.opendev.org/c/openstack/releases/+/887238\n\nBased on that, I believe what you have here is correct.",
"parentUuid": "c31f2bd9_76f3d440",
"range": {
"startLine": 147,
"startChar": 0,
"endLine": 148,
"endChar": 63
},
"revId": "0cbbb407a9e4e80ab9657d00fe1f78baf3f76046",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "249096b8_8bd2abe7",
"filename": "doc/source/repository.rst",
"patchSetId": 1
},
"lineNbr": 148,
"author": {
"id": 17685
},
"writtenOn": "2024-01-11T10:31:08Z",
"side": 1,
"message": "I also forgot about this \u0027retired\u0027 flag, but yepp, that\u0027s an existing thing. Thanks Sean for the example!\n\nMaybe the new section can be added next to this, since these are somewhat related and in that case it\u0027s probably more clear.",
"parentUuid": "c31383cf_4519a174",
"range": {
"startLine": 147,
"startChar": 0,
"endLine": 148,
"endChar": 63
},
"revId": "0cbbb407a9e4e80ab9657d00fe1f78baf3f76046",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "9e8f3477_e6d8a2fd",
"filename": "doc/source/repository.rst",
"patchSetId": 1
},
"lineNbr": 148,
"author": {
"id": 5314
},
"writtenOn": "2024-01-11T14:07:12Z",
"side": 1,
"message": "@Sean thanks for the example, that does make this clear. What I think is going on is:\n\nRetirement: everything stops now. So we completely remove the deliverable\u0027s yaml file for the current cycle (because no release has ever happened there). We aren\u0027t continuing maintenance on the stable branches, so we add the \u0027retired\u0027 flag to the non-EOL stable branches\u0027 yaml files (we don\u0027t delete because the yaml files contain historical info about the releases that *have* happened).\n\nDeprecation: no more development in master, but continued support for the stable branches. So remove the deliverable\u0027s yaml file for the current cycle. Don\u0027t do anything to the stable branches yaml files because we have the option to do new releases from there.\n\nSo it looks like my patch is correct for the Deprecation case; I think we can give a bit more explanation for the Retirement case in a followup patch (assuming that my comments here are correct).",
"parentUuid": "249096b8_8bd2abe7",
"range": {
"startLine": 147,
"startChar": 0,
"endLine": 148,
"endChar": 63
},
"revId": "0cbbb407a9e4e80ab9657d00fe1f78baf3f76046",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5a8f4412_7f30ca27",
"filename": "doc/source/repository.rst",
"patchSetId": 1
},
"lineNbr": 148,
"author": {
"id": 8556
},
"writtenOn": "2024-01-11T21:58:27Z",
"side": 1,
"message": "Current. for retired repo we need to remove file from current release if that exist. I might have missed that step in my original write up here but agree to add that also here with example (https://review.opendev.org/c/openstack/releases/+/887238)",
"parentUuid": "9e8f3477_e6d8a2fd",
"range": {
"startLine": 147,
"startChar": 0,
"endLine": 148,
"endChar": 63
},
"revId": "0cbbb407a9e4e80ab9657d00fe1f78baf3f76046",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5bb081b5_617e58c0",
"filename": "doc/source/repository.rst",
"patchSetId": 1
},
"lineNbr": 218,
"author": {
"id": 17685
},
"writtenOn": "2024-01-11T10:31:08Z",
"side": 1,
"message": "nit: i got comments in the past that we should not use \u0027names\u0027 (Fresca) for a coming release, because it can confuse people or something like that o:)",
"revId": "0cbbb407a9e4e80ab9657d00fe1f78baf3f76046",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "2e9a77f1_d4e46683",
"filename": "doc/source/repository.rst",
"patchSetId": 1
},
"lineNbr": 218,
"author": {
"id": 13252
},
"writtenOn": "2024-01-11T20:27:08Z",
"side": 1,
"message": "I think that\u0027s a valid point, what\u0027s wrong with using \"2024.1\" and \"Caracal\"?",
"parentUuid": "5bb081b5_617e58c0",
"revId": "0cbbb407a9e4e80ab9657d00fe1f78baf3f76046",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f323b8b4_1fcaf314",
"filename": "doc/source/repository.rst",
"patchSetId": 1
},
"lineNbr": 218,
"author": {
"id": 5314
},
"writtenOn": "2024-01-11T21:48:38Z",
"side": 1,
"message": "My reasoning is that by the time people read this, Carcal will be released and then it will be confusing about whether we\u0027re talking about master or an existing branch. On the other hand, 2025 is only a year away and then the confusion will be back. I\u0027ll change this to 2999.2 (Xylophone), and then it should be obvious that it\u0027s an example not to be confused with a real release.",
"parentUuid": "2e9a77f1_d4e46683",
"revId": "0cbbb407a9e4e80ab9657d00fe1f78baf3f76046",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f550983e_ecf4aebb",
"filename": "doc/source/repository.rst",
"patchSetId": 1
},
"lineNbr": 218,
"author": {
"id": 5314
},
"writtenOn": "2024-01-11T21:52:24Z",
"side": 1,
"message": "Done",
"parentUuid": "f323b8b4_1fcaf314",
"revId": "0cbbb407a9e4e80ab9657d00fe1f78baf3f76046",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink