openstack
/
puppet-cloudkitty
Code Issues Proposed changes

Add strict validation about boolean parameters 

This ensures the parameters used by if-else logic accept only boolean
values because non-boolean can result in unexpected behavior.

Change-Id: I20a381329797402627cb14a6104014fae7ac839d
This commit is contained in:
Takashi Kajinami 2023-06-16 02:37:47 +09:00
parent 7fdd4f56cf
commit 86c16519e2
3 changed files with 34 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
manifests/api.pp
View File

@ -51,12 +51,12 @@
#
class cloudkitty::api (
$package_ensure = 'present',
$manage_service = true,
$enabled = true,
Boolean $manage_service = true,
Boolean $enabled = true,
$host_ip = $facts['os_service_default'],
$port = $facts['os_service_default'],
$pecan_debug = $facts['os_service_default'],
$sync_db = true,
Boolean $sync_db = true,
$service_name = 'httpd',
$enable_proxy_headers_parsing = $facts['os_service_default'],
$max_request_body_size = $facts['os_service_default'],

36
manifests/keystone/auth.pp
View File

@ -83,24 +83,24 @@
#
class cloudkitty::keystone::auth (
$password,
$auth_name = 'cloudkitty',
$email = 'cloudkitty@localhost',
$tenant = 'services',
$roles = ['admin'],
$system_scope = 'all',
$system_roles = [],
$configure_endpoint = true,
$configure_user = true,
$configure_user_role = true,
$service_name = 'cloudkitty',
$service_description = 'OpenStack Rating Service',
$service_type = 'rating',
$region = 'RegionOne',
$public_url = 'http://127.0.0.1:8889',
$admin_url = 'http://127.0.0.1:8889',
$internal_url = 'http://127.0.0.1:8889',
$manage_rating_role = true,
$rating_role = 'rating',
$auth_name = 'cloudkitty',
$email = 'cloudkitty@localhost',
$tenant = 'services',
$roles = ['admin'],
$system_scope = 'all',
$system_roles = [],
$configure_endpoint = true,
$configure_user = true,
$configure_user_role = true,
$service_name = 'cloudkitty',
$service_description = 'OpenStack Rating Service',
$service_type = 'rating',
$region = 'RegionOne',
$public_url = 'http://127.0.0.1:8889',
$admin_url = 'http://127.0.0.1:8889',
$internal_url = 'http://127.0.0.1:8889',
Boolean $manage_rating_role = true,
$rating_role = 'rating',
) {
include cloudkitty::deps

26
manifests/processor.pp
View File

@ -59,20 +59,20 @@
# Default to $facts['os_service_default']
#
class cloudkitty::processor (
$package_ensure = 'present',
$manage_service = true,
$enabled = true,
$collector = 'gnocchi',
$window = $facts['os_service_default'],
$period = $facts['os_service_default'],
$wait_periods = $facts['os_service_default'],
$services = $facts['os_service_default'],
$auth_type = 'password',
$auth_section = 'keystone_authtoken',
$region_name = $facts['os_service_default'],
$interface = $facts['os_service_default'],
$package_ensure = 'present',
Boolean $manage_service = true,
Boolean $enabled = true,
$collector = 'gnocchi',
$window = $facts['os_service_default'],
$period = $facts['os_service_default'],
$wait_periods = $facts['os_service_default'],
$services = $facts['os_service_default'],
$auth_type = 'password',
$auth_section = 'keystone_authtoken',
$region_name = $facts['os_service_default'],
$interface = $facts['os_service_default'],
# DEPRECATED PARAMETERS
$max_workers = undef,
$max_workers = undef,
) {
include cloudkitty::deps