openstack
/
puppet-designate
Code Issues Proposed changes

Fix typo that would make the package name the service name 

Since the service and the package name can differ, it is important
to really choose the PACKAGE name and not the SERVICE name.
For example, in RDO, the package is
"openstack-designate-pool-manager" but the service is
"designate-pool-manager".

Additionally, the package name for "designate-pool-manager" is
"designate-pool-manager" in Ubuntu Cloud Archive [1]. Not
"openstack-designate-pool-manager".

[1]: http://ubuntu-cloud.archive.canonical.com/ubuntu/dists/xenial-updates/newton/main/binary-amd64/Packages

Change-Id: I1d0b9b66b7fb5ec97d0992c2efd58b63359d364d
This commit is contained in:
David Moreau-Simard 2016-07-04 21:50:06 -04:00
parent 1e7c4c6913
commit 5dcd51eca2
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/params.pp
View File

@ -36,7 +36,7 @@ class designate::params {
$agent_package_name = 'designate-agent'
$sink_package_name = 'designate-sink'
$pymysql_package_name = 'python-pymysql'
$pool_manager_package_name = 'openstack-designate-pool-manager'
$pool_manager_package_name = 'designate-pool-manager'
$mdns_package_name = 'designate-mdns'
# service names
$agent_service_name = 'designate-agent'

2
manifests/pool_manager.pp
View File

@ -115,7 +115,7 @@ class designate::pool_manager(
if $manage_package {
package { 'designate-pool-manager':
ensure => $package_ensure,
name => pick($pool_manager_package_name, $::designate::params::pool_manager_service_name),
name => pick($pool_manager_package_name, $::designate::params::pool_manager_package_name),
tag => ['openstack', 'designate-package'],
}
}