openstack
/
puppet-designate
Code Issues Proposed changes

Add support for sizelimit middleware option 

The sizelimit middleware was added to pipelines defined by the default
api-paste.ini file [1]. This adds support for the parameter of
the sizelimit middleware.

[1] c0a5572814e96f90d3d4b9ea0f10d35d88f5cd68

Change-Id: Ic3659225f4445c8b33e05157af76af4d11b45194
This commit is contained in:
Takashi Kajinami 2023-10-18 02:52:12 +09:00
parent bbcac63121
commit 90c4b48640
3 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
manifests/api.pp
View File

@ -94,6 +94,10 @@
# HTTPProxyToWSGI middleware.
# Defaults to $facts['os_service_default'].
#
# [*max_request_body_size*]
# (Optional) Set max request body size
# Defaults to $facts['os_service_default'].
#
# [*service_name*]
# (Optional) Name of the service that will be providing the server
# functionality of the designate API. If the value is 'httpd',
@ -124,6 +128,7 @@ class designate::api (
$enabled_extensions_admin = $facts['os_service_default'],
$quotas_verify_project_id = $facts['os_service_default'],
$enable_proxy_headers_parsing = $facts['os_service_default'],
$max_request_body_size = $facts['os_service_default'],
$service_name = $::designate::params::api_service_name,
) inherits designate {
@ -156,7 +161,8 @@ class designate::api (
}
oslo::middleware { 'designate_config':
enable_proxy_headers_parsing => $enable_proxy_headers_parsing
enable_proxy_headers_parsing => $enable_proxy_headers_parsing,
max_request_body_size => $max_request_body_size,
}
if $manage_service {

4
releasenotes/notes/max_request_body_size-7161406cb8b718b5.yaml Normal file
View File

@ -0,0 +1,4 @@
---
features:
- |
The new ``designate::api::max_request_body_size`` parameter has been added.

7
spec/classes/designate_api_spec.rb
View File

@ -56,7 +56,8 @@ describe 'designate::api' do
is_expected.to contain_designate_config('service:api/quotas_verify_project_id').with_value('<SERVICE DEFAULT>')
is_expected.to_not contain_designate__keystone__authtoken('designate_config')
is_expected.to contain_oslo__middleware('designate_config').with(
:enable_proxy_headers_parsing => '<SERVICE DEFAULT>'
:enable_proxy_headers_parsing => '<SERVICE DEFAULT>',
:max_request_body_size => '<SERVICE DEFAULT>',
)
end
end
@ -82,6 +83,7 @@ describe 'designate::api' do
:enabled_extensions_admin => 'reports,quotas,zones',
:quotas_verify_project_id => false,
:enable_proxy_headers_parsing => true,
:max_request_body_size => 102400,
})
end
@ -104,7 +106,8 @@ describe 'designate::api' do
is_expected.to contain_designate_config('service:api/enabled_extensions_admin').with_value(params[:enabled_extensions_admin])
is_expected.to contain_designate_config('service:api/quotas_verify_project_id').with_value(false)
is_expected.to contain_oslo__middleware('designate_config').with(
:enable_proxy_headers_parsing => params[:enable_proxy_headers_parsing]
:enable_proxy_headers_parsing => params[:enable_proxy_headers_parsing],
:max_request_body_size => params[:max_request_body_size],
)
end
end