diff --git a/manifests/client.pp b/manifests/client.pp index 4fa0a511..2c2df37c 100644 --- a/manifests/client.pp +++ b/manifests/client.pp @@ -13,7 +13,7 @@ # Defaults to $::designate::params::client_package_name # class designate::client ( - $package_ensure = 'present', + $package_ensure = 'present', $client_package_name = $::designate::params::client_package_name, ) inherits designate::params { @@ -22,7 +22,7 @@ class designate::client ( package { 'python-designateclient': ensure => $package_ensure, name => $client_package_name, - tag => 'openstack', + tag => ['openstack', 'openstackclient'], } include openstacklib::openstackclient diff --git a/spec/classes/designate_client_spec.rb b/spec/classes/designate_client_spec.rb index 0631b5e9..17128711 100644 --- a/spec/classes/designate_client_spec.rb +++ b/spec/classes/designate_client_spec.rb @@ -4,9 +4,6 @@ require 'spec_helper' describe 'designate::client' do - let :params do - { } - end shared_examples 'designate-client' do @@ -18,7 +15,7 @@ describe 'designate::client' do is_expected.to contain_package('python-designateclient').with( :ensure => 'present', :name => platform_params[:client_package_name], - :tag => 'openstack' + :tag => ['openstack', 'openstackclient'] ) end @@ -26,15 +23,15 @@ describe 'designate::client' do end context 'with custom package name' do - before do - params.merge!({ :client_package_name => 'designate-client-custom-name' }) + let :params do + { :client_package_name => 'designate-client-custom-name' } end it 'configures using custom name' do is_expected.to contain_package('python-designateclient').with( :ensure => 'present', :name => 'designate-client-custom-name', - :tag => 'openstack', + :tag => ['openstack', 'openstackclient'], ) end end