openstack
/
puppet-designate
Code Issues Proposed changes

Remove deprecated designate::worker::worker_notify 

... because the parameter was deprecated during Victoria cycle[1].

The actual parameter was already removed from Designate by [2].

[1] 3134f475ab
[2] 5d5d83e511acbf5d6f34e9a998ff16d96c5bb162

Change-Id: I9eb1e7d7e2463d21a52b347ccc8e8b1da9b975fc
This commit is contained in:
Takashi Kajinami 2022-08-16 21:41:40 +09:00
parent 316723aa21
commit b8ddf2b1f3
3 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
manifests/worker.pp
View File

@ -58,10 +58,6 @@
#
# DEPRECATED PARAMETERS
#
# [*worker_notify*]
# (optional) Whether to allow worker to send NOTIFYs.
# Defaults to undef
#
# [*manage_package*]
# Whether Puppet should manage the package.
# Default is undef.
@ -90,7 +86,6 @@ class designate::worker(
$export_synchronous = $::os_service_default,
$topic = $::os_service_default,
# DEPRECATED PARAMETERS
$worker_notify = undef,
$manage_package = undef,
$service_ensure = undef,
$worker_topic = undef,
@ -134,11 +129,4 @@ class designate::worker(
designate_config {
'service:worker/worker_topic': ensure => absent;
}
if $worker_notify != undef {
warning('worker_notify is deprecated and will be removed in a future release')
designate_config {
'service:worker/notify': value => $worker_notify;
}
}
}

4
releasenotes/notes/remove-worker-notify-d3a86bfdd6acbfdb.yaml Normal file
View File

@ -0,0 +1,4 @@
---
upgrade:
- |
The ``designate::worker::worker_notify`` parameter has beenremoved.

2
spec/classes/designate_worker_spec.rb
View File

@ -21,7 +21,6 @@ describe 'designate::worker' do
:poll_retry_interval => 10,
:poll_max_retries => 5,
:poll_delay => 1,
:worker_notify => true,
:export_synchronous => true,
:topic => 'topic',
}
@ -85,7 +84,6 @@ describe 'designate::worker' do
is_expected.to contain_designate_config('service:worker/poll_retry_interval').with_value( params[:poll_retry_interval] )
is_expected.to contain_designate_config('service:worker/poll_max_retries').with_value( params[:poll_max_retries] )
is_expected.to contain_designate_config('service:worker/poll_delay').with_value( params[:poll_delay] )
is_expected.to contain_designate_config('service:worker/notify').with_value( params[:worker_notify] )
is_expected.to contain_designate_config('service:worker/export_synchronous').with_value( params[:export_synchronous] )
is_expected.to contain_designate_config('service:worker/topic').with_value( params[:topic] )
end