From 1317af56d4f4700e4300024e5344c8b0ac780eeb Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Wed, 11 Oct 2023 11:59:09 +0900 Subject: [PATCH] Remove usage of deleted manifest_dir Recent update in rspec-puppet removed some of the config interfaces for old puppet versions[1]. This drops usage of these interfaces to resolve the following error in unit tests. ``` An error occurred while loading ./spec/unit/provider/manila_spec.rb. Failure/Error: c.manifest_dir = File.join(fixture_path, 'manifests') NoMethodError: undefined method `manifest_dir='... ``` This also removes explicit setting of mock module. The definition is no longer required since we bumped puppetlabs_spec_helper to v 5.0.0. [1] https://github.com/puppetlabs/rspec-puppet/commit/316d95923cdbab4daf980629cbded351dd61354c Change-Id: I3077eed14d4e4e2e29cb947ec4ec1fa06abd6229 --- spec/spec_helper.rb | 3 --- 1 file changed, 3 deletions(-) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index a99919e7..653e84d8 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -12,9 +12,6 @@ RSpec.configure do |c| c.alias_it_should_behave_like_to :it_raises, 'raises' c.module_path = File.join(fixture_path, 'modules') - c.manifest_dir = File.join(fixture_path, 'manifests') - - c.mock_with :rspec end at_exit { RSpec::Puppet::Coverage.report! }