diff --git a/lib/puppet/type/glance_api_config.rb b/lib/puppet/type/glance_api_config.rb index 80c7f6cc..0ccee169 100644 --- a/lib/puppet/type/glance_api_config.rb +++ b/lib/puppet/type/glance_api_config.rb @@ -40,4 +40,8 @@ Puppet::Type.newtype(:glance_api_config) do defaultto false end + autorequire(:package) do + 'glance-api' + end + end diff --git a/lib/puppet/type/glance_api_paste_ini.rb b/lib/puppet/type/glance_api_paste_ini.rb index daf4cc49..b97c08b1 100644 --- a/lib/puppet/type/glance_api_paste_ini.rb +++ b/lib/puppet/type/glance_api_paste_ini.rb @@ -40,4 +40,8 @@ Puppet::Type.newtype(:glance_api_paste_ini) do defaultto false end + autorequire(:package) do + 'glance-api' + end + end diff --git a/lib/puppet/type/glance_cache_config.rb b/lib/puppet/type/glance_cache_config.rb index 5f801fd7..f4650019 100644 --- a/lib/puppet/type/glance_cache_config.rb +++ b/lib/puppet/type/glance_cache_config.rb @@ -40,4 +40,8 @@ Puppet::Type.newtype(:glance_cache_config) do defaultto false end + autorequire(:package) do + 'glance-api' + end + end diff --git a/lib/puppet/type/glance_registry_config.rb b/lib/puppet/type/glance_registry_config.rb index 3291be39..31ece0e7 100644 --- a/lib/puppet/type/glance_registry_config.rb +++ b/lib/puppet/type/glance_registry_config.rb @@ -40,4 +40,8 @@ Puppet::Type.newtype(:glance_registry_config) do defaultto false end + autorequire(:package) do + 'glance-registry' + end + end diff --git a/lib/puppet/type/glance_registry_paste_ini.rb b/lib/puppet/type/glance_registry_paste_ini.rb index 1afeafd7..d6292fbb 100644 --- a/lib/puppet/type/glance_registry_paste_ini.rb +++ b/lib/puppet/type/glance_registry_paste_ini.rb @@ -40,4 +40,8 @@ Puppet::Type.newtype(:glance_registry_paste_ini) do defaultto false end + autorequire(:package) do + 'glance-registry' + end + end diff --git a/manifests/api.pp b/manifests/api.pp index 4e8e335b..d750c927 100644 --- a/manifests/api.pp +++ b/manifests/api.pp @@ -240,7 +240,7 @@ class glance::api( } if ( $glance::params::api_package_name != $glance::params::registry_package_name ) { - ensure_packages([$glance::params::api_package_name], + ensure_packages('glance-api', { ensure => $package_ensure, tag => ['openstack', 'glance-package'], @@ -250,8 +250,6 @@ class glance::api( Package[$glance::params::api_package_name] -> File['/etc/glance/'] Package[$glance::params::api_package_name] -> Class['glance::policy'] - Package[$glance::params::api_package_name] -> Glance_api_config<||> - Package[$glance::params::api_package_name] -> Glance_cache_config<||> # adding all of this stuff b/c it devstack says glance-api uses the # db now diff --git a/manifests/registry.pp b/manifests/registry.pp index 36e8f668..9a9b9bc7 100644 --- a/manifests/registry.pp +++ b/manifests/registry.pp @@ -169,7 +169,7 @@ class glance::registry( } if ( $glance::params::api_package_name != $glance::params::registry_package_name ) { - ensure_packages( [$glance::params::registry_package_name], + ensure_packages( 'glance-registry', { ensure => $package_ensure, tag => ['openstack', 'glance-package'], @@ -178,7 +178,6 @@ class glance::registry( } Package[$glance::params::registry_package_name] -> File['/etc/glance/'] - Package[$glance::params::registry_package_name] -> Glance_registry_config<||> Glance_registry_config<||> ~> Exec<| title == 'glance-manage db_sync' |> Glance_registry_config<||> ~> Service['glance-registry'] diff --git a/spec/unit/provider/glance_api_config/ini_setting_spec.rb b/spec/unit/provider/glance_api_config/ini_setting_spec.rb new file mode 100644 index 00000000..7e805d00 --- /dev/null +++ b/spec/unit/provider/glance_api_config/ini_setting_spec.rb @@ -0,0 +1,42 @@ +$LOAD_PATH.push( + File.join( + File.dirname(__FILE__), + '..', + '..', + '..', + 'fixtures', + 'modules', + 'inifile', + 'lib') +) + +require 'spec_helper' + +provider_class = Puppet::Type.type(:glance_api_config).provider(:ini_setting) + +describe provider_class do + + it 'should default to the default setting when no other one is specified' do + resource = Puppet::Type::Glance_api_config.new( + { + :name => 'DEFAULT/foo', + :value => 'bar' + } + ) + provider = provider_class.new(resource) + expect(provider.section).to eq('DEFAULT') + expect(provider.setting).to eq('foo') + end + + it 'should allow setting to be set explicitly' do + resource = Puppet::Type::Glance_api_config.new( + { + :name => 'dude/foo', + :value => 'bar' + } + ) + provider = provider_class.new(resource) + expect(provider.section).to eq('dude') + expect(provider.setting).to eq('foo') + end +end diff --git a/spec/unit/provider/glance_cache_config/ini_setting_spec.rb b/spec/unit/provider/glance_cache_config/ini_setting_spec.rb new file mode 100644 index 00000000..9a9a324f --- /dev/null +++ b/spec/unit/provider/glance_cache_config/ini_setting_spec.rb @@ -0,0 +1,42 @@ +$LOAD_PATH.push( + File.join( + File.dirname(__FILE__), + '..', + '..', + '..', + 'fixtures', + 'modules', + 'inifile', + 'lib') +) + +require 'spec_helper' + +provider_class = Puppet::Type.type(:glance_cache_config).provider(:ini_setting) + +describe provider_class do + + it 'should default to the default setting when no other one is specified' do + resource = Puppet::Type::Glance_cache_config.new( + { + :name => 'DEFAULT/foo', + :value => 'bar' + } + ) + provider = provider_class.new(resource) + expect(provider.section).to eq('DEFAULT') + expect(provider.setting).to eq('foo') + end + + it 'should allow setting to be set explicitly' do + resource = Puppet::Type::Glance_cache_config.new( + { + :name => 'dude/foo', + :value => 'bar' + } + ) + provider = provider_class.new(resource) + expect(provider.section).to eq('dude') + expect(provider.setting).to eq('foo') + end +end diff --git a/spec/unit/provider/glance_registry_config/ini_setting_spec.rb b/spec/unit/provider/glance_registry_config/ini_setting_spec.rb new file mode 100644 index 00000000..505be658 --- /dev/null +++ b/spec/unit/provider/glance_registry_config/ini_setting_spec.rb @@ -0,0 +1,42 @@ +$LOAD_PATH.push( + File.join( + File.dirname(__FILE__), + '..', + '..', + '..', + 'fixtures', + 'modules', + 'inifile', + 'lib') +) + +require 'spec_helper' + +provider_class = Puppet::Type.type(:glance_registry_config).provider(:ini_setting) + +describe provider_class do + + it 'should default to the default setting when no other one is specified' do + resource = Puppet::Type::Glance_registry_config.new( + { + :name => 'DEFAULT/foo', + :value => 'bar' + } + ) + provider = provider_class.new(resource) + expect(provider.section).to eq('DEFAULT') + expect(provider.setting).to eq('foo') + end + + it 'should allow setting to be set explicitly' do + resource = Puppet::Type::Glance_registry_config.new( + { + :name => 'dude/foo', + :value => 'bar' + } + ) + provider = provider_class.new(resource) + expect(provider.section).to eq('dude') + expect(provider.setting).to eq('foo') + end +end diff --git a/spec/unit/type/glance_api_config_spec.rb b/spec/unit/type/glance_api_config_spec.rb new file mode 100644 index 00000000..2d66caa1 --- /dev/null +++ b/spec/unit/type/glance_api_config_spec.rb @@ -0,0 +1,19 @@ +require 'puppet' +require 'puppet/type/glance_api_config' + +describe 'Puppet::Type.type(:glance_api_config)' do + before :each do + @glance_api_config = Puppet::Type.type(:glance_api_config).new(:name => 'DEFAULT/foo', :value => 'bar') + end + + it 'should autorequire the package that install the file' do + catalog = Puppet::Resource::Catalog.new + package = Puppet::Type.type(:package).new(:name => 'glance-api') + catalog.add_resource package, @glance_api_config + dependency = @glance_api_config.autorequire + expect(dependency.size).to eq(1) + expect(dependency[0].target).to eq(@glance_api_config) + expect(dependency[0].source).to eq(package) + end + +end diff --git a/spec/unit/type/glance_cache_config_spec.rb b/spec/unit/type/glance_cache_config_spec.rb new file mode 100644 index 00000000..840ddec8 --- /dev/null +++ b/spec/unit/type/glance_cache_config_spec.rb @@ -0,0 +1,19 @@ +require 'puppet' +require 'puppet/type/glance_cache_config' + +describe 'Puppet::Type.type(:glance_cache_config)' do + before :each do + @glance_cache_config = Puppet::Type.type(:glance_cache_config).new(:name => 'DEFAULT/foo', :value => 'bar') + end + + it 'should autorequire the package that install the file' do + catalog = Puppet::Resource::Catalog.new + package = Puppet::Type.type(:package).new(:name => 'glance-api') + catalog.add_resource package, @glance_cache_config + dependency = @glance_cache_config.autorequire + expect(dependency.size).to eq(1) + expect(dependency[0].target).to eq(@glance_cache_config) + expect(dependency[0].source).to eq(package) + end + +end diff --git a/spec/unit/type/glance_registry_config_spec.rb b/spec/unit/type/glance_registry_config_spec.rb new file mode 100644 index 00000000..9e6fbcdf --- /dev/null +++ b/spec/unit/type/glance_registry_config_spec.rb @@ -0,0 +1,19 @@ +require 'puppet' +require 'puppet/type/glance_registry_config' + +describe 'Puppet::Type.type(:glance_registry_config)' do + before :each do + @glance_registry_config = Puppet::Type.type(:glance_registry_config).new(:name => 'DEFAULT/foo', :value => 'bar') + end + + it 'should autorequire the package that install the file' do + catalog = Puppet::Resource::Catalog.new + package = Puppet::Type.type(:package).new(:name => 'glance-registry') + catalog.add_resource package, @glance_registry_config + dependency = @glance_registry_config.autorequire + expect(dependency.size).to eq(1) + expect(dependency[0].target).to eq(@glance_registry_config) + expect(dependency[0].source).to eq(package) + end + +end