openstack
/
puppet-nova
Code Issues Proposed changes

Drop redundant default of send_service_user_token 

The option defaults to False, so we don't need the explicit default and
can replace it by os_service_default fact.

Change-Id: Idd35189e279f3b6990f80c2eca80b7fa16c38e1f
This commit is contained in:
Takashi Kajinami 2024-01-23 14:39:04 +09:00
parent 885ed333e3
commit 51a01e3968
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/keystone/service_user.pp
View File

@ -34,7 +34,7 @@
#
# [*send_service_user_token*]
# (Optional) The service uses service token feature when this is set as true
# Defaults to 'false'
# Defaults to $facts['os_service_default']
#
# [*insecure*]
# (Optional) If true, explicitly allow TLS without checking server cert
@ -75,7 +75,7 @@ class nova::keystone::service_user(
$user_domain_name = 'Default',
$project_domain_name = 'Default',
$system_scope = $facts['os_service_default'],
$send_service_user_token = false,
$send_service_user_token = $facts['os_service_default'],
$insecure = $facts['os_service_default'],
$auth_type = 'password',
$auth_version = $facts['os_service_default'],

2
spec/classes/nova_keystone_service_user_spec.rb
View File

@ -22,7 +22,7 @@ describe 'nova::keystone::service_user' do
:project_domain_name => 'Default',
:system_scope => '<SERVICE DEFAULT>',
:insecure => '<SERVICE DEFAULT>',
:send_service_user_token => false,
:send_service_user_token => '<SERVICE DEFAULT>',
:auth_type => 'password',
:auth_version => '<SERVICE DEFAULT>',
:cafile => '<SERVICE DEFAULT>',