openstack
/
puppet-oslo
Code Issues Proposed changes

Do not assert implementation in puppet-postgresql 

... but assert the class we include to manage the backend package.

Change-Id: If768923ee96de531a575152ba3ea5aeb0591e926
This commit is contained in:
Takashi Kajinami 2023-07-27 11:12:16 +09:00
parent 386021e502
commit 62c1b56cc0
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spec/defines/oslo_db_spec.rb
View File

@ -89,9 +89,8 @@ describe 'oslo::db' do
{ :connection => 'postgresql://db:db@localhost/db', }
end
it 'install the proper backend package' do
is_expected.to contain_package('python-psycopg2').with(:ensure => 'present')
end
it { is_expected.to contain_keystone_config('database/connection').with_value('postgresql://db:db@localhost/db').with_secret(true) }
it { is_expected.to contain_class('postgresql::lib::python') }
context 'with backend package management disabled' do
before do
@ -101,7 +100,7 @@ describe 'oslo::db' do
end
it 'does not install backend package' do
is_expected.not_to contain_package('python-psycopg2')
is_expected.not_to contain_class('postgresql::lib::python')
end
end
end
@ -112,6 +111,7 @@ describe 'oslo::db' do
end
it { is_expected.to contain_keystone_config('database/connection').with_value('postgresql+psycopg2://db:db@localhost/db').with_secret(true) }
it { is_expected.to contain_class('postgresql::lib::python') }
end
context 'with incorrect database_connection string' do