openstack
/
puppet-ovn
Code Issues Proposed changes

controller: Ensure boolean values 

Some parameters are used in if-else logic and non-boolean values can
cause unexpected results.

Change-Id: I8b8bcf883bc8907e6436785dd2a0e698785e3a13
This commit is contained in:
Takashi Kajinami 2023-02-25 23:52:37 +09:00
parent a5cb9fd56a
commit f875236386
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
manifests/controller.pp
View File

@ -136,6 +136,11 @@ class ovn::controller(
include ovn::params
validate_legacy(Boolean, 'validate_bool', $enable_dpdk)
validate_legacy(String, 'validate_string', $ovn_remote)
validate_legacy(String, 'validate_string', $ovn_encap_ip)
validate_legacy(Boolean, 'validate_bool', $manage_ovs_bridge)
if $enable_dpdk and ! $datapath_type {
fail('Datapath type must be set when DPDK is enabled')
}
@ -148,9 +153,6 @@ class ovn::controller(
include stdlib
validate_legacy(String, 'validate_string', $ovn_remote)
validate_legacy(String, 'validate_string', $ovn_encap_ip)
service { 'controller':
ensure => true,
name => $::ovn::params::ovn_controller_service_name,