openstack
/
puppet-tacker
Code Issues Proposed changes

Add notifications parameters 

Add notification_transport_url to configure a URL representing the
messaging driver to use for notifications.
Add notification_driver to configure driver or drivers to handle
sending notifications.
Add notification_topics to configure AMQP topic used for OpenStack
notifications.

Change-Id: I203d60575ea1359dd5c661beea53bb4899b258bd
This commit is contained in:
ZhongShengping 2017-03-10 09:09:00 +08:00
parent 31d276f8fe
commit 013ab25523
3 changed files with 43 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
manifests/init.pp
View File

@ -9,6 +9,21 @@
# (Optional) Use these options to configure the RabbitMQ message system.
# Defaults to 'rabbit'
#
# [*notification_transport_url*]
# (optional) A URL representing the messaging driver to use for notifications
# and its full configuration. Transport URLs take the form:
# transport://user:pass@host1:port[,hostN:portN]/virtual_host
# Defaults to $::os_service_default
#
# [*notification_topics*]
# (optional) AMQP topics to publish to when using the RPC notification driver.
# (list value)
# Default to $::os_service_default
#
# [*notification_driver*]
# (Optional) Notification driver to use
# Defaults to $::os_service_default
#
# [*default_transport_url*]
# (optional) A URL representing the messaging driver to use and its full
# configuration. Transport URLs take the form:
@ -159,6 +174,9 @@
#
class tacker(
$rpc_backend = 'rabbit',
$notification_transport_url = $::os_service_default,
$notification_driver = $::os_service_default,
$notification_topics = $::os_service_default,
$default_transport_url = $::os_service_default,
$rpc_response_timeout = $::os_service_default,
$control_exchange = $::os_service_default,
@ -241,4 +259,11 @@ class tacker(
rpc_response_timeout => $rpc_response_timeout,
control_exchange => $control_exchange,
}
oslo::messaging::notifications { 'tacker_config':
transport_url => $notification_transport_url,
driver => $notification_driver,
topics => $notification_topics,
}
}

9
releasenotes/notes/add_messaging_notification_parameters-183a35d7635f9227.yaml Normal file
View File

@ -0,0 +1,9 @@
---
features:
- Add new parameter "notification_transport_url", A URL
representing the messaging driver to use for notifications
and its full configuration.
- Add new parameter "notification_topics", AMQP topic used for
OpenStack notifications.
- Add new parameter "notification_driver", driver or drivers to
handle sending notifications.

9
spec/classes/tacker_init_spec.rb
View File

@ -26,6 +26,9 @@ describe 'tacker' do
is_expected.to contain_tacker_config('oslo_messaging_rabbit/heartbeat_timeout_threshold').with_value('<SERVICE DEFAULT>')
is_expected.to contain_tacker_config('oslo_messaging_rabbit/heartbeat_rate').with_value('<SERVICE DEFAULT>')
is_expected.to contain_tacker_config('oslo_messaging_rabbit/kombu_compression').with_value('<SERVICE DEFAULT>')
is_expected.to contain_tacker_config('oslo_messaging_notifications/transport_url').with_value('<SERVICE DEFAULT>')
is_expected.to contain_tacker_config('oslo_messaging_notifications/driver').with_value('<SERVICE DEFAULT>')
is_expected.to contain_tacker_config('oslo_messaging_notifications/topics').with_value('<SERVICE DEFAULT>')
end
end
@ -40,6 +43,9 @@ describe 'tacker' do
:rabbit_heartbeat_timeout_threshold => '60',
:rabbit_heartbeat_rate => '10',
:kombu_compression => 'gzip',
:notification_transport_url => 'rabbit://user:pass@host:1234/virt',
:notification_topics => 'openstack',
:notification_driver => 'messagingv1',
}
end
@ -51,6 +57,9 @@ describe 'tacker' do
is_expected.to contain_tacker_config('oslo_messaging_rabbit/heartbeat_timeout_threshold').with_value('60')
is_expected.to contain_tacker_config('oslo_messaging_rabbit/heartbeat_rate').with_value('10')
is_expected.to contain_tacker_config('oslo_messaging_rabbit/kombu_compression').with_value('gzip')
is_expected.to contain_tacker_config('oslo_messaging_notifications/transport_url').with_value('rabbit://user:pass@host:1234/virt')
is_expected.to contain_tacker_config('oslo_messaging_notifications/driver').with_value('messagingv1')
is_expected.to contain_tacker_config('oslo_messaging_notifications/topics').with_value('openstack')
end
end