From 24d30a384ea81b7b0b462d56a3d5a0c85022ca47 Mon Sep 17 00:00:00 2001 From: Brian Rosmaita Date: Thu, 17 Jun 2021 08:40:18 -0400 Subject: [PATCH] Remove skip_missing_interpreters The Zuul results on [0], for example, show the functional-py36 job as passing, when actually no tests were run because a py36 interpreter was not available. So don't allow this to happen, and change the default testenvs to test generic "py3" instead of py36 and py38. This kind of sucks because someone might test locally against a py3 version we don't even support, but it's either that or require that developers have both py36 and py38 available on their systems ... which most of us do. But the wider community, as far as I can tell, thinks that requirement is unreasonable and that it would discourage new contributors. This requires a corresponding change in the zuul config file so that the functional-py36 job explicitly requires that py36 be available. And because explicit is better than implicit, the requirement is also added to the functional-py38 job definition. [0] https://review.opendev.org/c/openstack/python-brick-cinderclient-ext/+/796787/1 Change-Id: Iba7c25dd51dd0b91909b083272a8d5efc853115e --- .zuul.yaml | 4 ++++ tox.ini | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.zuul.yaml b/.zuul.yaml index 30bd5c8..010709d 100644 --- a/.zuul.yaml +++ b/.zuul.yaml @@ -48,13 +48,17 @@ - job: name: brick-cinderclient-dsvm-functional-py36 parent: brick-cinderclient-dsvm-functional-base + # need to specify a platform that has python 3.6 available + nodeset: devstack-single-node-centos-8-stream vars: + python_version: 3.6 tox_envlist: functional-py36 - job: name: brick-cinderclient-dsvm-functional-py38 parent: brick-cinderclient-dsvm-functional-base vars: + python_version: 3.8 tox_envlist: functional-py38 - project: diff --git a/tox.ini b/tox.ini index 4975d0b..cd74652 100644 --- a/tox.ini +++ b/tox.ini @@ -1,9 +1,8 @@ [tox] minversion = 3.1.0 skipsdist = True -skip_missing_interpreters = true # python runtimes: https://governance.openstack.org/tc/reference/project-testing-interface.html#tested-runtimes -envlist = py38,py36,pep8 +envlist = py3,pep8 # this allows tox to infer the base python from the environment name # and override any basepython configured in this file ignore_basepython_conflict=true