python-glanceclient/glanceclient
ckonstanski 03900522d4 v2: Content-Type: application/octet-stream header always added
The bug: any existing Content-Type header cannot be found because the
call to headers.get() fails. Therefore we end up with two Content-Type
headers because a new one (applicaion/octet-stream) gets added
unconditionally. The cause: the strings (keys and values) in the headers
dict are converted from unicode sequences of type <str> to utf-8
sequences of type <bytes>. This happens in safe_encode()
(oslo_utils/encodeutils.py:66). <str> != <bytes> even if they appear to
have the same characters.

Hence, for python 3.x, _set_common_request_kwargs() adds content-type
to header even if custom content-type is set in the request.

This results in unsupported media type exception when glance client
is used with keystoneauth and python 3.x

The fix: follow the directions in encode_headers().
It says to do this just before sending the request. Honor this principle;
do not encode headers and then perform more business logic on them.

Change-Id: Idf6079b32f70bc171f5016467048e917d42f296d
Closes-bug: #1641239
Co-Authored-By: Pushkar Umaranikar <pushkar.umaranikar@intel.com>
2017-05-19 19:02:00 +00:00
..
common v2: Content-Type: application/octet-stream header always added 2017-05-19 19:02:00 +00:00
tests v2: Content-Type: application/octet-stream header always added 2017-05-19 19:02:00 +00:00
v1 Add ploop in disk_format 2017-01-19 14:31:01 +00:00
v2 Merge "Replace dict.iteritems() with dict.items()" 2017-01-24 22:34:49 +00:00
__init__.py Enable flake8 checks 2015-07-21 17:08:27 +03:00
_i18n.py Do not fall back to namespaced oslo.i18n 2015-06-24 16:56:56 -05:00
client.py Use import_versioned_module from oslo.utils 2016-12-06 09:35:55 +00:00
exc.py py3: Fix encoding and use sys.stdin.buffer 2016-07-25 20:13:08 +05:30
shell.py Merge "Handle formatting of subcommand name in error output" 2017-01-13 19:35:35 +00:00