openstack
/
python-ironic-inspector-client
Code Issues Proposed changes

Set safe version of hacking 

Versions of hacking from 3.1.0 until 4.0.0 NOT included are supposed
to require a safe version of flake8, so besides normale issues related
to minor version upgrades, we can safely use those versions.
Also forcing pycodestyle versions to be compatible with flake8 installed
by hacking.

Plus correcting output of empty response from ironic-inspector changed in
6e2cb60e77

Change-Id: I0c07a99b23898ce6a8c715caf44ac70f649631fb
This commit is contained in:
Riccardo Pittau 2020-10-19 11:28:35 +02:00
parent d6c40b7a85
commit 9d93604226
3 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
functest-requirements.txt
View File

@ -1,4 +1,4 @@
# NOTE(jroll) these are pinned to the same SHA, update when needed.
# Last updated: May 14, 2020 (Victoria cycle).
git+https://opendev.org/openstack/ironic-inspector@721bd814a61cd4dec433465fff55a5235853c9a2#egg=ironic-inspector
-r https://opendev.org/openstack/ironic-inspector/raw/commit/721bd814a61cd4dec433465fff55a5235853c9a2/test-requirements.txt
# Last updated: October 27, 2020 (Wallaby cycle).
git+https://opendev.org/openstack/ironic-inspector@5678f219cd55345633c1478c3cad22460bef4429#egg=ironic-inspector
-r https://opendev.org/openstack/ironic-inspector/raw/commit/5678f219cd55345633c1478c3cad22460bef4429/test-requirements.txt

4
ironic_inspector_client/test/functional.py
View File

@ -141,7 +141,7 @@ class TestV1PythonAPI(functional.Base):
res = self.client.reprocess(self.uuid)
self.assertEqual(202, res.status_code)
self.assertEqual('', res.text)
self.assertEqual('{}\n', res.text)
eventlet.greenthread.sleep(functional.DEFAULT_SLEEP)
self.check_status(status, finished=True, state=istate.States.finished)
@ -166,7 +166,7 @@ class TestV1PythonAPI(functional.Base):
eventlet.greenthread.sleep(functional.DEFAULT_SLEEP)
self.assertEqual(202, res.status_code)
self.assertEqual('', res.text)
self.assertEqual('{}\n', res.text)
status = self.client.get_status(self.uuid)
self.check_status(status, finished=True, state=istate.States.error,

3
test-requirements.txt
View File

@ -5,10 +5,11 @@ coverage>=5.0 # Apache-2.0
doc8>=0.6.0 # Apache-2.0
fixtures>=3.0.0 # Apache-2.0/BSD
flake8-import-order>=0.17.1 # LGPLv3
hacking>=3.0.0,<3.1.0 # Apache-2.0
hacking>=3.1.0,<4.0.0 # Apache-2.0
requests-mock>=1.2.0 # Apache-2.0
oslo.concurrency>=3.25.0 # Apache-2.0
osc-lib>=2.1.0 # Apache-2.0
pycodestyle>=2.0.0,<2.7.0 # MIT
python-openstackclient>=3.12.0 # Apache-2.0
# Required for syntax highlighting check
Pygments>=2.2.0 # BSD