From 96c304b9b71d64d7a68a390a8a3e12f4cf1f9983 Mon Sep 17 00:00:00 2001 From: Vu Cong Tuan Date: Wed, 7 Jun 2017 14:49:24 +0700 Subject: [PATCH] Change assertTrue(isinstance()) by optimal assert Some of tests use different method of assertTrue(isinstance(A, B)). The correct way is to use assertIsInstance(A,B) provided by testtools. Change-Id: Ib04a2fd4b6545bf41b14b4366c11f4d7329227e6 Closes-bug: #1268480 --- magnumclient/tests/test_httpclient.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/magnumclient/tests/test_httpclient.py b/magnumclient/tests/test_httpclient.py index c9bbcebd..205ff141 100644 --- a/magnumclient/tests/test_httpclient.py +++ b/magnumclient/tests/test_httpclient.py @@ -333,7 +333,7 @@ class HttpClientTest(utils.BaseTestCase): resp, body = client.json_request('GET', '/v1/resources') self.assertEqual(resp, fake_resp) - self.assertTrue(isinstance(body, list)) + self.assertIsInstance(body, list) def test_server_success_body_json(self): err = _get_error_body()