openstack
/
python-magnumclient
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Attention: {"person_ident":"Gerrit User 35271 \u003c35271@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_35271\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 8064 \u003c8064@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_35271\u003e replied on the change"}
This commit is contained in:
Gerrit User 35271 2023-10-23 08:44:52 +00:00 committed by Gerrit Code Review
parent 3d38a540c6
commit afc5d1f02c
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
dae4d336d6c8dee64e45c4db8ad9b5c49f13c58f
View File

@ -22,6 +22,30 @@
},
"revId": "dae4d336d6c8dee64e45c4db8ad9b5c49f13c58f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "558a3c23_663957d1",
"filename": "magnumclient/common/httpclient.py",
"patchSetId": 1
},
"lineNbr": 331,
"author": {
"id": 35271
},
"writtenOn": "2023-10-23T08:44:52Z",
"side": 1,
"message": "I think the original subsequent \u0027self.user_agent\u003dUSER_AGENT\u0027 is wrong, which value is always the const global var USER_AGENT, then the param user_agent, whatever value you pass, is useless.",
"parentUuid": "5c0ec133_0984b0a2",
"range": {
"startLine": 331,
"startChar": 34,
"endLine": 331,
"endChar": 38
},
"revId": "dae4d336d6c8dee64e45c4db8ad9b5c49f13c58f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}