From 806e660654c1384bda5897c16e9cb4a32c8b6022 Mon Sep 17 00:00:00 2001
From: yatin <yatin.karel@nectechnologies.in>
Date: Mon, 23 Jan 2017 17:08:36 +0530
Subject: [PATCH] Increase UT Coverage

UT Coverage for following is increased:
- magnumclient/tests/v1/test_certificates_shell.py
- magnumclient/tests/test_utils.py

Change-Id: If15aaf9206599126dde14d237bb56b52222ea0cf
Partially-Implements: blueprint magnumclient-ut-coverage
---
 magnumclient/tests/test_utils.py                 |  8 ++++++++
 magnumclient/tests/v1/test_certificates_shell.py | 13 +++++++++++++
 2 files changed, 21 insertions(+)

diff --git a/magnumclient/tests/test_utils.py b/magnumclient/tests/test_utils.py
index 7bef0203..93a96fe4 100644
--- a/magnumclient/tests/test_utils.py
+++ b/magnumclient/tests/test_utils.py
@@ -108,6 +108,14 @@ class ArgsArrayToPatchTest(test_utils.BaseTestCase):
         self.assertEqual([{'op': 'remove', 'path': '/foo'},
                           {'op': 'remove', 'path': '/extra/bar'}], patch)
 
+    def test_args_array_to_patch_invalid_op(self):
+        my_args = {
+            'attributes': ['/foo', 'extra/bar'],
+            'op': 'invalid',
+        }
+        self.assertRaises(exc.CommandError, utils.args_array_to_patch,
+                          my_args['op'], my_args['attributes'])
+
 
 class FormatLabelsTest(test_utils.BaseTestCase):
 
diff --git a/magnumclient/tests/v1/test_certificates_shell.py b/magnumclient/tests/v1/test_certificates_shell.py
index bddc0be2..77b4b955 100644
--- a/magnumclient/tests/v1/test_certificates_shell.py
+++ b/magnumclient/tests/v1/test_certificates_shell.py
@@ -14,6 +14,7 @@
 
 import mock
 
+from magnumclient.common import cliutils as utils
 from magnumclient.tests.v1 import shell_test_base
 from magnumclient.v1 import certificates_shell
 
@@ -129,3 +130,15 @@ class ShellTest(shell_test_base.TestCommandLineArgument):
             mock_isfile.assert_called_once_with('path/csr.pem')
             mock_file.assert_not_called()
             mock_cert_create.assert_not_called()
+
+    @mock.patch('magnumclient.v1.clusters.ClusterManager.get')
+    @mock.patch('magnumclient.v1.certificates.CertificateManager.get')
+    def test_ca_show_failure_with_invalid_field(self, mock_cert_get,
+                                                mock_cluster_get):
+        _error_msg = [".*?^--cluster or --bay"]
+        self.assertRaises(utils.MissingArgs,
+                          self._test_arg_failure,
+                          'ca-show',
+                          _error_msg)
+        mock_cert_get.assert_not_called()
+        mock_cluster_get.assert_not_called()