openstack
/
python-manilaclient
Code Issues Proposed changes

Clean imports in code 

In some part in the code we import objects. In the Openstack style guidelines
they recommend to import only modules. [1]: "Do not import objects, only modules".

[1] https://docs.openstack.org/hacking/0.10.3/

Change-Id: If31aa24f74db73ab925f6568d3c8653228b6e9c6
This commit is contained in:
Nguyen Hung Phuong 2018-01-30 14:29:56 +07:00
parent 27c189f0f3
commit 8415a4c4e1
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
doc/source/exts/clidoc/__init__.py
View File

@ -14,14 +14,14 @@
import os import os
import sys import sys
from cStringIO import StringIO import cStringIO
def _get_cli_output(): def _get_cli_output():
stdout_org = sys.stdout stdout_org = sys.stdout
sys.stdout = output = StringIO() sys.stdout = output = cStringIO.StringIO()
from manilaclient.shell import OpenStackManilaShell from manilaclient import shell
shell = OpenStackManilaShell() shell = shell.OpenStackManilaShell()
shell.main(None) shell.main(None)
sys.stdout = stdout_org sys.stdout = stdout_org
output.seek(0) output.seek(0)