openstack
/
python-manilaclient
Code Issues Proposed changes

Update patch set 10 

Patch Set 10:

(3 comments)

Patch-set: 10
Attention: {"person_ident":"Gerrit User 36889 \u003c36889@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36889\u003e replied on the change"}
This commit is contained in:
Gerrit User 36889 2024-04-08 18:05:17 +00:00 committed by Gerrit Code Review
parent 779e48edf5
commit b167df7d0d
2 changed files with 69 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
7c0b6fc4963a3b931212fec65a6257e4ac51bc19
View File

@ -40,6 +40,30 @@
"revId": "7c0b6fc4963a3b931212fec65a6257e4ac51bc19",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "d1a9c430_d815ed4d",
"filename": "manilaclient/v2/shell.py",
"patchSetId": 9
},
"lineNbr": 395,
"author": {
"id": 36889
},
"writtenOn": "2024-04-08T18:05:17Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "1909421a_deaacac4",
"range": {
"startLine": 390,
"startChar": 0,
"endLine": 395,
"endChar": 51
},
"revId": "7c0b6fc4963a3b931212fec65a6257e4ac51bc19",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -62,6 +86,30 @@
},
"revId": "7c0b6fc4963a3b931212fec65a6257e4ac51bc19",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4bf62fe1_57ba6f79",
"filename": "manilaclient/v2/shell.py",
"patchSetId": 9
},
"lineNbr": 4660,
"author": {
"id": 36889
},
"writtenOn": "2024-04-08T18:05:17Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "d1d60344_2a85b650",
"range": {
"startLine": 4658,
"startChar": 0,
"endLine": 4660,
"endChar": 43
},
"revId": "7c0b6fc4963a3b931212fec65a6257e4ac51bc19",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

21
c2a9b04dc844d2e321e2ff448ab826b3ca0e9d5d Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "0e2effc1_1d72d1d6",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 10
},
"lineNbr": 0,
"author": {
"id": 36889
},
"writtenOn": "2024-04-08T18:05:17Z",
"side": 1,
"message": "Thanks for the reference, popped 2 keys",
"revId": "c2a9b04dc844d2e321e2ff448ab826b3ca0e9d5d",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}