Hacking version update and pep8 issues fix

Updated the version of hacking to match global requirements [1] and
fixed several pep8 issues exposed with the new version.

The list of fixed issues:
    - W292 no newline at end of file
    - H238  old style class declaration

[1] https://github.com/openstack/requirements/blob/master/global-requirements.txt

Change-Id: I2de0d2ed9d6e0a893290053998877ba30093f636
This commit is contained in:
David Sariel 2016-05-04 15:54:43 +03:00
parent 80fc72a72a
commit cfa9f4b2bc
3 changed files with 4 additions and 4 deletions

View File

@ -199,4 +199,4 @@ class HTTPClient(object):
'code': resp.status_code,
'headers': resp.headers,
'body': resp.text
})
})

View File

@ -869,7 +869,7 @@ class ShellTest(test_utils.TestCase):
def test_extract_metadata(self):
# mimic the result of argparse's parse_args() method
class Arguments:
class Arguments(object):
def __init__(self, metadata=None):
if metadata is None:
metadata = []
@ -1371,7 +1371,7 @@ class ShellTest(test_utils.TestCase):
@mock.patch.object(cliutils, 'print_list', mock.Mock())
@mock.patch.object(shell_v2, '_find_share_network', mock.Mock())
def test_security_service_list_filter_share_network(self):
class FakeShareNetwork:
class FakeShareNetwork(object):
id = 'fake-sn-id'
sn = FakeShareNetwork()
shell_v2._find_share_network.return_value = sn

View File

@ -3,7 +3,7 @@
# process, which may cause wedges in the gate later.
# hacking should be first
hacking<0.10,>=0.9.2
hacking>=0.10.2,<0.11 # Apache-2.0
coverage>=3.6 # Apache-2.0
ddt>=1.0.1 # MIT