openstack
/
python-manilaclient
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 36889 \u003c36889@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
This commit is contained in:
Gerrit User 9816 2024-03-28 14:23:02 +00:00 committed by Gerrit Code Review
parent dfb5245351
commit e6f5b7084f
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
af7940a3ea1b0e254d5b5751a69bf6642307115b
View File

@ -94,6 +94,30 @@
},
"revId": "af7940a3ea1b0e254d5b5751a69bf6642307115b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "30207428_efc2ca66",
"filename": "manilaclient/v2/shell.py",
"patchSetId": 2
},
"lineNbr": 422,
"author": {
"id": 9816
},
"writtenOn": "2024-03-28T14:23:02Z",
"side": 1,
"message": "The problem is that the run_command method does not simulate how shell handles \"\" or \u0027\u0027 so what is tested in test_list_filter_by_metadata_with_only_empty_metadata behaves differently so the current tests passing does not mean the usage via shell is actually fixed.",
"parentUuid": "86697448_4e40f5cc",
"range": {
"startLine": 422,
"startChar": 27,
"endLine": 422,
"endChar": 31
},
"revId": "af7940a3ea1b0e254d5b5751a69bf6642307115b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}