openstack
/
python-openstackclient
Code Issues Proposed changes

Update patch set 11 

Patch Set 11:

(6 comments)

Patch-set: 11
This commit is contained in:
Gerrit User 36482 2024-04-22 21:29:37 +00:00 committed by Gerrit Code Review
parent b1733a77b2
commit 217c97be8d
2 changed files with 114 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
11a00f148375250030306d2fe881f003439d1bca
View File

@ -34,6 +34,24 @@
"revId": "11a00f148375250030306d2fe881f003439d1bca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "296910c9_3283eac3",
"filename": "openstackclient/tests/unit/identity/v3/test_role_assignment.py",
"patchSetId": 10
},
"lineNbr": 50,
"author": {
"id": 36482
},
"writtenOn": "2024-04-22T21:29:37Z",
"side": 1,
"message": "Done",
"parentUuid": "40050b55_95ef1d4f",
"revId": "11a00f148375250030306d2fe881f003439d1bca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -51,6 +69,24 @@
"revId": "11a00f148375250030306d2fe881f003439d1bca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "0d34fecd_e7b6fe3a",
"filename": "openstackclient/tests/unit/identity/v3/test_role_assignment.py",
"patchSetId": 10
},
"lineNbr": 129,
"author": {
"id": 36482
},
"writtenOn": "2024-04-22T21:29:37Z",
"side": 1,
"message": "Done",
"parentUuid": "6e9dc409_c481468f",
"revId": "11a00f148375250030306d2fe881f003439d1bca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -68,6 +104,24 @@
"revId": "11a00f148375250030306d2fe881f003439d1bca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "19634d0d_0bc5c0b6",
"filename": "openstackclient/tests/unit/identity/v3/test_role_assignment.py",
"patchSetId": 10
},
"lineNbr": 171,
"author": {
"id": 36482
},
"writtenOn": "2024-04-22T21:29:37Z",
"side": 1,
"message": "Done",
"parentUuid": "0d36d60f_0c47f85c",
"revId": "11a00f148375250030306d2fe881f003439d1bca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -84,6 +138,24 @@
"message": "...and a fake `Group` object here.\n\nSame comments all the way down.",
"revId": "11a00f148375250030306d2fe881f003439d1bca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "79bdaab6_a3c97683",
"filename": "openstackclient/tests/unit/identity/v3/test_role_assignment.py",
"patchSetId": 10
},
"lineNbr": 193,
"author": {
"id": 36482
},
"writtenOn": "2024-04-22T21:29:37Z",
"side": 1,
"message": "Done",
"parentUuid": "b516e126_5e63dcde",
"revId": "11a00f148375250030306d2fe881f003439d1bca",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

42
72eee3c883e0fb714ba9ae26df22598404e1459f
View File

@ -64,6 +64,30 @@
"revId": "72eee3c883e0fb714ba9ae26df22598404e1459f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "49b0aac9_0a514aa9",
"filename": "openstackclient/identity/v3/role_assignment.py",
"patchSetId": 2
},
"lineNbr": 56,
"author": {
"id": 36482
},
"writtenOn": "2024-04-22T21:29:37Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "224d378a_79c4411c",
"range": {
"startLine": 56,
"startChar": 15,
"endLine": 56,
"endChar": 48
},
"revId": "72eee3c883e0fb714ba9ae26df22598404e1459f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -312,6 +336,24 @@
"revId": "72eee3c883e0fb714ba9ae26df22598404e1459f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "155d3c08_fdcc1a88",
"filename": "openstackclient/identity/v3/role_assignment.py",
"patchSetId": 2
},
"lineNbr": 240,
"author": {
"id": 36482
},
"writtenOn": "2024-04-22T21:29:37Z",
"side": 1,
"message": "Done",
"parentUuid": "093390a0_423a6f42",
"revId": "72eee3c883e0fb714ba9ae26df22598404e1459f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {