openstack
/
python-openstackclient
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(2 comments)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 8313 \u003c8313@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8313\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 15334 \u003c15334@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8313\u003e replied on the change"}
This commit is contained in:
Gerrit User 8313 2024-04-10 07:57:24 +00:00 committed by Gerrit Code Review
parent f1c2ffca99
commit 688fc3da30
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
c02fdb546e8552cda6084a7c13b4f739bbc38941
View File

@ -17,6 +17,24 @@
"revId": "c02fdb546e8552cda6084a7c13b4f739bbc38941",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ff72845a_f5f91bb7",
"filename": "openstackclient/network/v2/router.py",
"patchSetId": 6
},
"lineNbr": 574,
"author": {
"id": 8313
},
"writtenOn": "2024-04-10T07:57:24Z",
"side": 1,
"message": "yeah, to tell the truth I don\u0027t remember why I added that check, it seems unnecessary really.",
"parentUuid": "8483a723_7c58558e",
"revId": "c02fdb546e8552cda6084a7c13b4f739bbc38941",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -33,6 +51,24 @@
"message": "How about\n\n```\nThe ``router create --flavor-id`` parameter has been deprecated\nin favour of the ``--flavor`` parameter, which accepts both\nflavor names and flavor IDs.\n```\n\n?",
"revId": "c02fdb546e8552cda6084a7c13b4f739bbc38941",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f2ac2836_6c31e629",
"filename": "releasenotes/notes/Router-flavor-accepts-name-or-id-e9cecafcddf81cb2.yaml",
"patchSetId": 6
},
"lineNbr": 5,
"author": {
"id": 8313
},
"writtenOn": "2024-04-10T07:57:24Z",
"side": 1,
"message": "sounds better",
"parentUuid": "13016e46_6ed00ac9",
"revId": "c02fdb546e8552cda6084a7c13b4f739bbc38941",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}