openstack
/
python-openstackclient
Code Issues Proposed changes

Return nothing from volume backup restore 

current code just fails, and apparently there's not so much
useful info to atually return w/o making additinal API calls.
So we at least exit with 0 now.

Change-Id: Ic934e3b5aa6b35e6ee8caac42222b44624a34348
Closes-Bug: #2063335
This commit is contained in:
Pavlo Shchelokovskyy 2024-04-24 16:25:25 +03:00
parent a79cb608b0
commit 85e53c49b1
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
openstackclient/tests/unit/volume/v2/test_volume_backup.py
View File

@ -516,7 +516,7 @@ class TestBackupRestore(TestBackup):
volume_id=None,
name=None,
)
self.assertIsNotNone(result)
self.assertIsNone(result)
def test_backup_restore_with_volume(self):
self.volume_sdk_client.find_volume.side_effect = (

2
openstackclient/volume/v2/volume_backup.py
View File

@ -434,7 +434,7 @@ class RestoreVolumeBackup(command.ShowOne):
)
raise exceptions.CommandError(msg % parsed_args.volume)
return volume_client.restore_backup(
volume_client.restore_backup(
backup.id,
volume_id=volume_id,
name=volume_name,