openstack
/
python-openstackclient
Code Issues Proposed changes

Update patch set 1 

Abandoned

Patch-set: 1
Status: abandoned
Tag: autogenerated:gerrit:abandon
This commit is contained in:
Gerrit User 15334 2024-04-26 11:39:05 +00:00 committed by Gerrit Code Review
parent 57e5007c7a
commit d609ac369b
1 changed files with 81 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

85
e4e07090c977646e7cefb9c47e5d3d69d4cb9ab7
View File

@ -1,6 +1,7 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "3fa7e38b_49b9ac13",
"filename": "/COMMIT_MSG",
@ -14,10 +15,10 @@
"side": 1,
"message": "Summary line should be one line with a blank line between it and the full description.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure",
"revId": "e4e07090c977646e7cefb9c47e5d3d69d4cb9ab7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "3fa7e38b_0935f4a7",
"filename": "/COMMIT_MSG",
@ -31,8 +32,84 @@
"side": 1,
"message": "Unfortunately since this was submitted, we now use storyboard to track issues. This will need to be updated. I believe all launchpad bugs were migrated over.",
"revId": "e4e07090c977646e7cefb9c47e5d3d69d4cb9ab7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
],
"submitRequirementResults": [
{
"submitRequirement": {
"name": "Code-Review",
"description": {
"value": "Code reviewed by core reviewer"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Code-Review=MAX","label:Code-Review=MIN"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "e4e07090c977646e7cefb9c47e5d3d69d4cb9ab7",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Verified",
"description": {
"value": "Verified in gate by CI"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Verified=MAX","label:Verified=MIN"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "e4e07090c977646e7cefb9c47e5d3d69d4cb9ab7",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Workflow",
"description": {
"value": "Approved for gate by core reviewer"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Workflow=MAX","label:Workflow=MIN"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "e4e07090c977646e7cefb9c47e5d3d69d4cb9ab7",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
}
]
}