From 9c655a97b7fd1abffe0fcec69c66c581b2ac5228 Mon Sep 17 00:00:00 2001
From: Emilien Macchi <emilien@redhat.com>
Date: Thu, 26 Mar 2020 13:14:27 -0400
Subject: [PATCH] tripleo_deploy: finish the loop of operations early if wrong
 rc

If one of the operations running Ansible playbooks returns a wrong rc,
leave the loop and go to final tasks before raising.

It'll prevent the upgrade tasks to fail but the other playbooks (e.g.
deploy) to keep running.

Closes-Bug: #1869230
Change-Id: I5b1bb964ed290c860e66074202c45d7dd09bf29c
---
 tripleoclient/v1/tripleo_deploy.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tripleoclient/v1/tripleo_deploy.py b/tripleoclient/v1/tripleo_deploy.py
index e292b0efd..c413f6dbe 100644
--- a/tripleoclient/v1/tripleo_deploy.py
+++ b/tripleoclient/v1/tripleo_deploy.py
@@ -1323,6 +1323,8 @@ class Deploy(command.Command):
                             fail_on_rc=False,
                             **operation
                         )[0]
+                        if rc != 0:
+                            break
         except Exception as e:
             self.log.error("Exception: %s" % six.text_type(e))
             self.log.error(traceback.print_exc())