From f29a52fc075e993923f664a4e2e9d3c9c72acd38 Mon Sep 17 00:00:00 2001 From: Dirk Mueller Date: Mon, 16 Jul 2018 17:26:59 +0200 Subject: [PATCH] Adding python-ldap to global requirements To allow other openstack projects switch from the deprecated pyldap library to python-ldap we need to enable it as part of global-requirements. After the transition path is complete we can remove pyldap (which is merely a wrapper around python-ldap meanwhile, so it is effectively a noop). Is the library actively maintained? Yes - last release less than two months ago Is the library good code? Should be, it was the best of breedh from old ldap module and pyldap (which introduced api fixes for python 3.x compatibility) Is the library python 3 compatible? Yes Is the library license compatible? Yes - PSF Is the library already packaged in the distros we target (Ubuntu latest / Fedora latest)? Yes, already part of Ubuntu Bionic. Is the function of this library already covered by other libraries in global-requirements.txt? Yes, pyldap is the deprecated but already contained library. Is the library required for OpenStack project or related dev or infrastructure setup? (Answer to this should be Yes, of course) Which? Yes, needed by keystone and others. Change-Id: I671675ca967502bae803ab510f9d9d3c0d58a60d --- global-requirements.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/global-requirements.txt b/global-requirements.txt index 736919b522..6588509fe9 100644 --- a/global-requirements.txt +++ b/global-requirements.txt @@ -206,6 +206,7 @@ pyinotify;sys_platform!='win32' and sys_platform!='darwin' and sys_platform!='su PyJWT # MIT pykafka # Apache 2.0 License pykmip # Apache 2.0 License +python-ldap # PSF pyldap # PSF pylxd # Apache-2.0 pymemcache!=1.3.0 # Apache 2.0 License