Ensure WORKINPROGRESS reviews are at the bottom of the list.
WORKINPROGRESS reviews should not be at the top of the reviewday list for a given project. The score will always be 0 for WIP reviews and the subject line (in the generated report) will be prefixed with a '(WIP): ' to indicate it is work-in-progress. Change-Id: I32f7e08341dcbf1a0aa965a5f377c7fdc8613ead
This commit is contained in:
parent
ad588336ac
commit
02b04c151c
|
@ -64,6 +64,7 @@ class MergeProp(object):
|
|||
self.revision = review['currentPatchSet']['revision']
|
||||
self.refspec = review['currentPatchSet']['ref']
|
||||
self.revisionCreatedOn = review['currentPatchSet']['createdOn']
|
||||
self.status = review['status']
|
||||
self.number = review['number']
|
||||
self.jobs = smoker.jobs(self.revision[:7])
|
||||
self.feedback = []
|
||||
|
@ -81,6 +82,11 @@ class MergeProp(object):
|
|||
|
||||
# Make use of the feedback in calculating the score
|
||||
cause, reason, score = self._calc_score(lp, cur_timestamp)
|
||||
if self.status == 'WORKINPROGRESS':
|
||||
# if the review status is WIP, always make it a score of 0 and
|
||||
# adjust the subject to indicate it's a WIP
|
||||
score = 0
|
||||
self.subject = '(WIP): %s' % self.subject
|
||||
self.score = score
|
||||
self.reason = reason
|
||||
self.cause = cause
|
||||
|
|
Loading…
Reference in New Issue