diff --git a/reviewday/html_helper.py b/reviewday/html_helper.py index 9e8e64a..e39bde3 100644 --- a/reviewday/html_helper.py +++ b/reviewday/html_helper.py @@ -23,11 +23,15 @@ def fail_status(job_data, token): def review_feedback(mp): return ' '.join(mp.feedback) -def lowest_feedback(mp): - if mp.lowest_feedback is None: +def display_feedback(mp): + if mp.lowest_feedback is None or mp.highest_feedback is None: return '' + if mp.lowest_feedback > 0: + report_value = mp.highest_feedback color = '#00AA00' else: + report_value = mp.lowest_feedback color = '#FF0000' - return '%+d' % (color, mp.lowest_feedback) + + return '%+d' % (color, report_value) diff --git a/reviewday/mergeprop.py b/reviewday/mergeprop.py index 977c84b..dee98d4 100644 --- a/reviewday/mergeprop.py +++ b/reviewday/mergeprop.py @@ -16,7 +16,7 @@ class MergeProp(object): if spec: cause = '%s feature' % spec.priority except: - print 'WARNING: unabled to find cause for %s' % topic + print 'WARNING: unable to find cause for %s' % topic cause = 'No link' cause_score = { @@ -55,11 +55,14 @@ class MergeProp(object): self.cause = cause self.jobs = smoker.jobs(self.revision[:7]) self.feedback = [] - min_value = None + + self.lowest_feedback = None + self.highest_feedback = None + for approval in review['currentPatchSet'].get('approvals', []): name = approval['by']['name'] value = int(approval['value']) self.feedback.append('%s: %+d' % (name, value)) - if min_value is None or min_value > value: - min_value = value - self.lowest_feedback = min_value + + self.lowest_feedback = min(self.lowest_feedback, value) or value + self.highest_feedback = max(self.highest_feedback, value) or value diff --git a/reviewday/report.html b/reviewday/report.html index 11893bc..9c9cea3 100644 --- a/reviewday/report.html +++ b/reviewday/report.html @@ -85,7 +85,7 @@ $mp.score - $helper.lowest_feedback($mp) + $helper.display_feedback($mp)