Update patch set 4

Patch Set 4: Code-Review-1 (5 comments) Patch-set: 4 Label: Code-Review=-1
2017-03-07 18:39:00 +00:00 · 2017-03-07 18:39:00 +00:00 · ffc0b85686
parent 3b1662782c
commit ffc0b85686
1 changed files with 101 additions and 0 deletions
--- a/101
+++ b/101
@ -0,0 +1,101 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "9a30ddce_6f87c00f",
+        "filename": "reviewday/create_gate_fail_dash.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 1,
+      "author": {
+        "id": 9656
+      },
+      "writtenOn": "2017-03-07T18:39:00Z",
+      "side": 1,
+      "message": "the file should be renamed into something neutron specific, and go into bin/, maybe bin/neutron-ci",
+      "revId": "b9c63262a3ebc22baa02b9d0dbf829e717128746",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9a30ddce_1bc2fd85",
+        "filename": "reviewday/create_gate_fail_dash.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 3,
+      "author": {
+        "id": 9656
+      },
+      "writtenOn": "2017-03-07T18:39:00Z",
+      "side": 1,
+      "message": "I see a lot of similarities between bin/neutron and this script. Please refactor and reuse the code where it\u0027s possible. Or maybe we should just squash this dashboard into existing one and just allocate a new section for gate related fixes.",
+      "revId": "b9c63262a3ebc22baa02b9d0dbf829e717128746",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9a30ddce_afcb7871",
+        "filename": "reviewday/create_gate_fail_dash.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 28,
+      "author": {
+        "id": 9656
+      },
+      "writtenOn": "2017-03-07T18:39:00Z",
+      "side": 1,
+      "message": "hm what are they for?",
+      "range": {
+        "startLine": 27,
+        "startChar": 0,
+        "endLine": 28,
+        "endChar": 20
+      },
+      "revId": "b9c63262a3ebc22baa02b9d0dbf829e717128746",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9a30ddce_1bf75dd4",
+        "filename": "reviewday/create_gate_fail_dash.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 66,
+      "author": {
+        "id": 9656
+      },
+      "writtenOn": "2017-03-07T18:39:00Z",
+      "side": 1,
+      "message": "we don\u0027t have a huge number of fixes at any single time, so maybe just put them into a single section.",
+      "range": {
+        "startLine": 62,
+        "startChar": 4,
+        "endLine": 66,
+        "endChar": 73
+      },
+      "revId": "b9c63262a3ebc22baa02b9d0dbf829e717128746",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9a30ddce_bbabb188",
+        "filename": "reviewday/create_gate_fail_dash.py",
+        "patchSetId": 4
+      },
+      "lineNbr": 87,
+      "author": {
+        "id": 9656
+      },
+      "writtenOn": "2017-03-07T18:39:00Z",
+      "side": 1,
+      "message": "that ideally would capture stadium projects too. Consider reusing what bin/neutron already does. (I tend to think we need to extend the existing dashboard instead of writing a completely new one).",
+      "revId": "b9c63262a3ebc22baa02b9d0dbf829e717128746",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}